Open
Conversation
andywhittle
commented
Apr 30, 2025
andywhittle
commented
- Updating to go 1.24 and updating all dependencies.
- Fixing specs (only running on latest golang version)
- Switch go lint for vet / staticcheck as that package has been deprecated
- Fix linter suggestions (disabling staticcheck ST1005 rule)
Disabling coveralls as that relates to the upstream repo, we would need to setup a different repo
fmtpolice run failed due to these formatting issues
Go vet complains of a pass lock by value due to the presence of sync Pool on the API struct. Using a pointer receiver here to avoid the linter complaint.
Disabling ST1005 check as this changes how the errors are handled due to capitilisation. Leaving this unchanged for now
Locking go mod to recent go and updating packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.