Skip to content

Conversation

@Robotgiggle
Copy link
Contributor

@Robotgiggle Robotgiggle commented Dec 27, 2025

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Hex Casting Dec 27, 2025
@Robotgiggle Robotgiggle changed the title Only apply media_consumption_modifier to casts using PlayerBasedCastEnv Exploit fixes for media_consumption attribute Jan 16, 2026
@Real-Luxof
Copy link

Real-Luxof commented Jan 16, 2026

lapisworks:deposit should be added to that config list.

Also heads up: in the 1.5.8 update for Lapisworks coming When It's Done™, lapisworks:imbue_lap will instead pull amethyst shards from the player's inventory, so it's inclusion will become unnecessary.

P.S. that config list does not look very modular for any future addons.

@Robotgiggle
Copy link
Contributor Author

Ok, added lapisworks:deposit. What exactly do you mean by it not being modular? The list in HexConfig.java is just the default values, users and packmakers can put whatever they want in there.

@Robotgiggle Robotgiggle marked this pull request as draft January 16, 2026 07:12
@Robotgiggle Robotgiggle marked this pull request as ready for review January 16, 2026 09:31
CHANGELOG.md Outdated
Comment on lines 7 to 15
## `0.11.4` - ???

### Added

- Added the `cannot_modify_cost` tag for patterns that should ignore the `media_consumption` attribute when calculating cost, by Robotgiggle in [987](https://github.com/FallingColors/HexMod/pull/987)

### Changed

- Changed the `media_consumption` attribute to only apply to player-based casting, by Robotgiggle in [987](https://github.com/FallingColors/HexMod/pull/987)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## `0.11.4` - ???
### Added
- Added the `cannot_modify_cost` tag for patterns that should ignore the `media_consumption` attribute when calculating cost, by Robotgiggle in [987](https://github.com/FallingColors/HexMod/pull/987)
### Changed
- Changed the `media_consumption` attribute to only apply to player-based casting, by Robotgiggle in [987](https://github.com/FallingColors/HexMod/pull/987)
## [UNRELEASED]
### Added
- Added the `cannot_modify_cost` tag for patterns that should ignore the `media_consumption` attribute when calculating cost, by Robotgiggle in [987](https://github.com/FallingColors/HexMod/pull/987).
### Changed
- Changed the `media_consumption` attribute to only apply to player-based casting, by Robotgiggle in [987](https://github.com/FallingColors/HexMod/pull/987).

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🏗 In progress in Hex Casting Jan 17, 2026
Copy link
Member

@object-Object object-Object left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@object-Object object-Object added this pull request to the merge queue Jan 18, 2026
Merged via the queue into FallingColors:main with commit 6286da3 Jan 18, 2026
8 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Hex Casting Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Media Consumption Modifier attribute affects non-player proxy casters

3 participants