-
Notifications
You must be signed in to change notification settings - Fork 110
Exploit fixes for media_consumption attribute #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exploit fixes for media_consumption attribute #987
Conversation
|
Also heads up: in the 1.5.8 update for Lapisworks coming When It's Done™, P.S. that config list does not look very modular for any future addons. |
|
Ok, added |
14d1ca0 to
97c3be7
Compare
CHANGELOG.md
Outdated
| ## `0.11.4` - ??? | ||
|
|
||
| ### Added | ||
|
|
||
| - Added the `cannot_modify_cost` tag for patterns that should ignore the `media_consumption` attribute when calculating cost, by Robotgiggle in [987](https://github.com/FallingColors/HexMod/pull/987) | ||
|
|
||
| ### Changed | ||
|
|
||
| - Changed the `media_consumption` attribute to only apply to player-based casting, by Robotgiggle in [987](https://github.com/FallingColors/HexMod/pull/987) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## `0.11.4` - ??? | |
| ### Added | |
| - Added the `cannot_modify_cost` tag for patterns that should ignore the `media_consumption` attribute when calculating cost, by Robotgiggle in [987](https://github.com/FallingColors/HexMod/pull/987) | |
| ### Changed | |
| - Changed the `media_consumption` attribute to only apply to player-based casting, by Robotgiggle in [987](https://github.com/FallingColors/HexMod/pull/987) | |
| ## [UNRELEASED] | |
| ### Added | |
| - Added the `cannot_modify_cost` tag for patterns that should ignore the `media_consumption` attribute when calculating cost, by Robotgiggle in [987](https://github.com/FallingColors/HexMod/pull/987). | |
| ### Changed | |
| - Changed the `media_consumption` attribute to only apply to player-based casting, by Robotgiggle in [987](https://github.com/FallingColors/HexMod/pull/987). |
Common/src/main/java/at/petrak/hexcasting/api/casting/eval/CastingEnvironment.java
Outdated
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/eval/CastingEnvironment.java
Outdated
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/datagen/tag/HexActionTagProvider.java
Outdated
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/iota/PatternIota.java
Outdated
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/eval/CastingEnvironment.java
Outdated
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/eval/CastingEnvironment.java
Outdated
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/eval/env/PlayerBasedCastEnv.java
Outdated
Show resolved
Hide resolved
object-Object
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
cannot_modify_cost) for patterns that should not have their costs modified