Open
Conversation
xurxodev
changed the base branch from
feature/remove_invalid_include_exclude_on_save
to
development
…ummary_as_email # Conflicts: # i18n/en.pot # i18n/es.po # i18n/fr.po # i18n/pt.po # src/data/common/utils/futures.ts # src/presentation/CompositionRoot.ts
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Member
|
@xurxodev to add a "disclaimer" checkbox letting the user know that some data will be shared. Message can be extracted from the feedback tool |
…ummary_as_email # Conflicts: # i18n/en.pot # i18n/es.po # i18n/fr.po # i18n/pt.po
Contributor
Author
|
@adrianq ready |
…ummary_as_email # Conflicts: # i18n/en.pot # src/presentation/CompositionRoot.ts
- To send email update it to public and external access - To send message update it to access for user or user group recipients only
…ummary_as_email # Conflicts: # i18n/en.pot # src/presentation/CompositionRoot.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
To send emails is necessary to configure an smtp server in dhis2. I've used gmail account using app password to work
📹 Screenshots/Screen capture
Screen.Recording.2025-03-27.at.10.38.42.mov
With privacy policy check
🔥 Is there anything the reviewer should know to test it?
Currently, there is a bug in 2.41 failing to access to external file using incognito window
https://dhis2.atlassian.net/browse/DHIS2-19544
📑 Others
Any change in the GUI library? If so, what branch/PR?
Any change in the D2 Api? If so, what branch/PR?