fix: Rejected PickingUp armor and 244 breaking pickup, and some refactor. #733
+51
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis1706
approved these changes
Jan 31, 2026
Someone-193
requested changes
Feb 2, 2026
Collaborator
Someone-193
left a comment
Someone-193
left a comment
There was a problem hiding this comment.
nothing obvious here looks wrong, minus a local variable declaration that could be moved. I'm assuming you tested all the methods that these transpilers modify?
| List<CodeInstruction> newInstructions = ListPool<CodeInstruction>.Pool.Get(instructions); | ||
|
|
||
| Label returnLabel = generator.DefineLabel(); | ||
| List<Label> logicLabels; |
Collaborator
There was a problem hiding this comment.
cant you move this declaration to the .ExtractLabels() call?
Author
yes know everthing works and scp244 and armors dont broken when you rejected |
Someone-193
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other