feat: new Voice chat event, fixes for Exiled events that use LabAPI, and additions to Event and Event<T> #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix item owner being done in the wrong order Revert "Fix item owner being done in the wrong order" This reverts commit e8cfd54. Update VoiceChatting.cs Update and rename VoiceChattingEventArgs.cs to SendingVoiceMessageEventArgs.cs Create ReceivingVoiceMessageEventArgs.cs Update Player.cs Update and rename ChangingSpeakerStatusAndVoiceChatting.cs to ChangingSpeakerStatus.cs Delete EXILED/Exiled.Events/EventArgs/Player/TransmittingEventArgs.cs Update Player.cs Create TransmittingEventArgs.cs Update Player.cs Update Player.cs Update Player.cs Update Player.cs Create VoiceChattingEventArgs.cs Update TransmittingEventArgs.cs Update Player.cs Update ReceivingVoiceMessageEventArgs.cs Update SendingVoiceMessageEventArgs.cs Update SendingVoiceMessageEventArgs.cs Update Player.cs Update Events.cs Update VoiceChatting.cs Update VoiceChatting.cs Update VoiceChatting.cs Update SendingVoiceMessageEventArgs.cs Update TransmittingEventArgs.cs Reverted braking changes deleted useless . doc checked its working /
…ther high-frequency events. This prevents EventArgs instantiation when no plugins are listening, significantly reducing GC pressure.
Update IPoolableEvent.cs
This reverts commit dafe934.
louis1706
approved these changes
Feb 2, 2026
Someone-193
requested changes
Feb 2, 2026
Collaborator
Someone-193
left a comment
Someone-193
left a comment
There was a problem hiding this comment.
Good PR all around, the ctor changes arent breaking imo so I'm good with them. You should rename the PR to indicate the misc changes you added (fixes for Exiled events that use LabAPI and the Patched bool for Event, which you should also implement for Event while you're making that change)
EXILED/Exiled.Events/EventArgs/Player/ReceivingVoiceMessageEventArgs.cs
Outdated
Show resolved
Hide resolved
EXILED/Exiled.Events/EventArgs/Player/ReceivingVoiceMessageEventArgs.cs
Outdated
Show resolved
Hide resolved
EXILED/Exiled.Events/EventArgs/Player/ReceivingVoiceMessageEventArgs.cs
Outdated
Show resolved
Hide resolved
Someone-193
changed the title
Someone-193
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other