Skip to content

Conversation

@MS-crew
Copy link

@MS-crew MS-crew commented Jan 27, 2026

Description

Describe the changes
image
image
image
image
image
image

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Someone-193
Copy link
Collaborator

I don't like the double parameter of player and players, cant you just stick to players and use .FirstOrDefault()? I think the change would make the methods a lot more readable imo, do you have any particular reasons for why you have both those parameters instead of one?

@MS-crew
Copy link
Author

MS-crew commented Feb 2, 2026

I don't like the double parameter of player and players, cant you just stick to players and use .FirstOrDefault()? I think the change would make the methods a lot more readable imo, do you have any particular reasons for why you have both those parameters instead of one?

@Someone-193 Then you would constantly need to create a new Ienumarable, and since these lines cannot be moved, perhaps developers might want to create new lines continuously and for short periods to update them. Wouldn't that create unnecessary garbage?

@Someone-193
Copy link
Collaborator

@Someone-193 Then you would constantly need to create a new Ienumarable, and since these lines cannot be moved, perhaps developers might want to create new lines continuously and for short periods to update them. Wouldn't that create unnecessary garbage?

I mean at that point they could use an ArrayPool or something, they could also re-use the same array if they're calling a draw method continuously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants