Add soundParam attribute for the Tileset XMLs + force a NoInlining on Player.DustParticleFromSurfaceIndex #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only soundParam and the forced NoInlining on the Dust Particles method
maddie480
added
the
review needed
Wartori54
reviewed
Jun 1, 2025
Member
Wartori54
left a comment
Wartori54
left a comment
There was a problem hiding this comment.
LGTM
(I'll approve once that commented out code is handled)
maddie480
approved these changes
Jun 10, 2025
JaThePlayer
approved these changes
Jun 11, 2025
Member
|
The pull request was approved and entered the 3-day last-call window. |
maddie480-bot
added
last call window
Wartori54
approved these changes
Jun 12, 2025
Member
|
The pull request was approved and entered the 3-day last-call window. |
Member
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
maddie480-bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are copied over from #867 to be merged in advance while the custom Particles implementation is being sorted out.
The additions include the following:
soundParamattribute forTileset:Makes this surface index play a different sound, by setting the
"surface_index"parameter to the value. For example, setting a value of"40"makes it play the Glitch sound. The purpose of this is to make new surface indices play already existing sounds without having to set up a different event for them. This is also useful in cases where a different event is used with thesoundPathattribute.Note: Defining a
soundattribute is required to use this, and it's recommended to set the value for thatsoundattribute greater than the range of already defined vanilla sounds (50is a good number to start from)NoInliningonPlayer.DustParticleFromSurfaceIndex:Makes
Player.DustParticleFromSurfaceIndexnot inline, meaning it can be hooked by code mods without any problems. For the time being, this can be used by coders to implement their own dust particles