Add Timeboost to AMI workflow #671
Conversation
.github/workflows/ami-release.yml
Outdated
| uses: actions/checkout@v5 | ||
|
|
||
| - name: Install Podman | ||
| uses: gacts/install-podman@v1 |
There was a problem hiding this comment.
According to https://github.com/actions/runner-images/blob/4e4e6cdb364028b0286aa4fc0a31f8f32036f57d/images/ubuntu/Ubuntu2404-Readme.md?plain=1#L90, podman is already installed. Is that version too old?
There was a problem hiding this comment.
No, this should be sufficient. Thanks.
Fixed.
packer/timeboost/justfile
Outdated
| MNT=$(podman image mount {{nitro-image}}) | ||
| cp $MNT/usr/local/bin/nitro {{target}} | ||
| podman image unmount {{nitro-image}} | ||
| podman unshare bash -c ' |
There was a problem hiding this comment.
Rootless podman did not work well for me locally. Can we use run0/sudo for the time being?
There was a problem hiding this comment.
same here i see:
Error: cannot run command "podman image mount" in rootless mode, must execute `podman unshare` first
There was a problem hiding this comment.
OK, thanks for testing this.
I’ve updated it so the CI environment variable controls which Podman approach is used.
This should work both locally with run0 (systemd ≥ 256) and in the AMI workflow runner.
akonring
force-pushed
the
ak/ami-workflow
branch
from
97b5289 to
5ba554f
Compare
| run0 bash -c ' | ||
| MNT=$(podman image mount {{nitro-image}}) | ||
| cp "$MNT/usr/local/bin/nitro" {{target}} | ||
| podman image unmount {{nitro-image}} | ||
| ' |
There was a problem hiding this comment.
| run0 bash -c ' | |
| MNT=$(podman image mount {{nitro-image}}) | |
| cp "$MNT/usr/local/bin/nitro" {{target}} | |
| podman image unmount {{nitro-image}} | |
| ' | |
| run0 bash -c ' | |
| podman pull ghcr.io/espressosystems/nitro-espresso-integration/{{nitro-image}} | |
| MNT=$(podman image mount {{nitro-image}}) | |
| cp "$MNT/usr/local/bin/nitro" {{target}} | |
| podman image unmount {{nitro-image}} | |
| ' |
I think the pull needs to happen with the same user. The pull in line 24 should then go into the if branch.
No description provided.