Open
Conversation
Eternali
changed the title
macterra
reviewed
Dec 20, 2018
| // updateIntervals.push(setInterval(function () { | ||
| // spawnCmd('node', [ 'scripts/peers.js' ]) | ||
| // }, settings.peer_timeout)) | ||
|
|
Author
There was a problem hiding this comment.
Sorry, I should mention, I'm still debugging a couple database issues (hence the 'WIP') and I just wanted to manually run the indexing myself for testing, this will be uncommented when I finish.
macterra
reviewed
Dec 20, 2018
lib/explorer.js
Outdated
| // { 'vin': { $elemMatch: { 'addresses': 'coinbase', 'amount': { $gt: 0 } } } } | ||
| // ).then(([ err, txes ]) => | ||
| // txes.reduce((sum, tx) => sum + tx.vin.find(vin => vin.addresses === 'coinbase').amount, 0) | ||
| // ) |
Author
There was a problem hiding this comment.
yes, there are a couple legacy ways the explorer was calculating total supply that I'll remove now that I've found that gettxoutsetinfo returns that info anyways.
macterra
approved these changes
Dec 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tx collection is gone.
Bitcoin-node-api is gone and replaced with custom caching solution.
UI improvements as well.