#41 [Shortener] add: rework extrafields + lib#104
Open
nicolas-eoxia wants to merge 2 commits intoEoxia:developfrom
Open
#41 [Shortener] add: rework extrafields + lib#104nicolas-eoxia wants to merge 2 commits intoEoxia:developfrom
nicolas-eoxia wants to merge 2 commits intoEoxia:developfrom
Conversation
| * @param string $urlMethod Url method | ||
| * @return int|stdClass 0 < on error, data object on success | ||
| */ | ||
| function init_easy_url_curl(array $curlPostFields, string $urlMethod = 'yourls') |
There was a problem hiding this comment.
peut être la fonction parce que init curl ça peut vouloir dire que tu init juste l'objet curl sans faire la requête alors là tu fais la requête.
Suggestion : easy_url_post comme nouveau nom de fonction ?
| // Fetch and return content | ||
| $data = curl_exec($ch); | ||
| curl_close($ch); | ||
|
|
There was a problem hiding this comment.
Rajouter une gestion d'erreur parce que si il y a une erreur il a peut être pas forcément de body en json
| foreach ($objects as $object) { | ||
| $urlTypes = ['signature', 'payment']; | ||
| foreach ($urlTypes as $urlType) { | ||
| if (isset($object->array_options['options_easy_url_' . $urlType . '_link']) && !empty($object->array_options['options_easy_url_' . $urlType . '_link'])) { |
There was a problem hiding this comment.
Pourquoi ne pas utiliser !empty() pour les deux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.