fix(dsmp): improve servo refresh rates to the module #6930
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankiearzu
changed the title
pfeerick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: For 2.11.5
Fixes #6931
Summary of changes:
Small fix to reduce the number of setup messages sent after startup and increase the servo refresh rate from the TX.
The original intention was:
During the Initial 3.5 seconds of power up the module, setup messages are sent every 3 messages (66ms),
After, only needed exporadically (1 every 100 messages, about 2.2 seconds).
But had a bug that kept sending setups every 3 messages forever, and that decreases the frequency of channel refresh messages from the TX to the DSMP and in some cases, while moving the servos from one side to the other, you notice a small delay/jump in the movement. Hardly noticeable, but this fixes it.