Skip to content

Conversation

@3djc
Copy link
Collaborator

@3djc 3djc commented Jan 1, 2026

Move led driver to generic_stm32

(Hopefully) no user impact

@3djc 3djc marked this pull request as draft January 1, 2026 13:10
@3djc 3djc marked this pull request as ready for review January 1, 2026 13:56
@3djc 3djc added the house keeping 🧹 Cleanup of code and house keeping label Jan 1, 2026
@3djc 3djc modified the milestones: 2.12.0, 3.0 Jan 1, 2026
@3djc 3djc marked this pull request as draft January 2, 2026 07:35
@3djc
Copy link
Collaborator Author

3djc commented Jan 2, 2026

Converted it to draft to prevent merge, need to do something for some FlySky radio that use atypical led setup

@3djc 3djc marked this pull request as ready for review January 2, 2026 08:08
@3djc
Copy link
Collaborator Author

3djc commented Jan 2, 2026

@pfeerick could you check PA01, PL18 and ST16 on radio itself ?

@pfeerick
Copy link
Member

pfeerick commented Jan 2, 2026

Sure will ;) aiming to try it out late tomorrow morning/early afternoon.

@pfeerick pfeerick changed the title chore: led driver chore: common led driver Jan 2, 2026
@philmoz
Copy link
Collaborator

philmoz commented Jan 2, 2026

PA01 seems ok.
ST16 build is broken in 2.12 and 3.0 (will not boot).

@pfeerick
Copy link
Member

pfeerick commented Jan 2, 2026

Right, managed to try it out sooner.

PA01 ok
PL18U ok
ST16 bootloader ok, firmware won't boot in this pr, main and 2.12, ok in 2.11.4. @richardclli Can you chase that one up? Just finished bisecting, 58932b4 is the offending PR / commit

Side note: NB4P ok on 2.12, and tried EL18 on main in last few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

house keeping 🧹 Cleanup of code and house keeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants