Material 3 #254
Material 3 #254
Conversation
PowerKiKi
left a comment
PowerKiKi
left a comment
There was a problem hiding this comment.
Deux trucs que j'ai repéré en parcourant un peu le code.
Co-authored-by: Adrien Crivelli <adrien.crivelli@gmail.com>
Co-authored-by: Adrien Crivelli <adrien.crivelli@gmail.com>
… automatically #11936
|
Je rouvre la PR, puisque la branche n'est pas encore mergée. |
Some old browsers don't support `light-dark()`. That's Safari < v17.5.
That's roughly ~9.3% of our users.
We can tolerate that they won't be able to switch between light and dark
anymore, but we must at least provide light colors as a fallback to
show _something_.
So we use a technique similar to this:
```css
:root {
--my-color: lightgray;
}
@supports (color: light-dark(white, black)) {
:root {
--my-color: light-dark(lightgray, darkgray);
}
}
body {
background: var(--my-color)
}
```
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 120 out of 124 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
And stop publishing on GitHub Packages because it does not provide any value
Because we didn't use in years
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 124 out of 128 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Because why not
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 124 out of 129 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
projects/natural/src/lib/modules/sidenav/sidenav-container/sidenav-container.component.scss:1
- Setting height to 0 on the host element could cause layout issues. If this is intentional for flex behavior, it should be documented with a comment explaining why.
projects/natural/src/lib/modules/table-button/table-button.component.ts:1 - The 'raised' input was removed but there's no migration path documented. This is a breaking change that should be noted in release documentation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PowerKiKi
left a comment
PowerKiKi
left a comment
There was a problem hiding this comment.
t'as ajouté 2 todo qu'on devrait pouvoir traiter avant de penser à merger
| } | ||
|
|
||
| [mat-row].selected { | ||
| // todo : remove ? when is it used ? |
There was a problem hiding this comment.
@sambaptista à traiter d'une façon ou d'une autre
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="icon" type="image/x-icon" href="favicon.ico" /> | ||
| <link href="https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500&display=swap" rel="stylesheet" /> | ||
| <!-- todo : remove ? <link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet" />--> |
There was a problem hiding this comment.
@sambaptista à traiter d'une façon ou d'une autre
Some Material components have touch target and/or focus indicator that are bigger than the actual component, making scrollbar to appears when they shouldn't. To avoid that we either increase the component size to match the touch target, or the opposite, reduce the touch target size to match the component size (and go against MD3 recommendation of 48px touch targets). We only reduce the touch target if the component has a label that make them naturally wide, and thus reasonably touchable. - Icon buttons are same as before MD3, with a bigger component (and still big touch target) - Buttons have smaller touch targets than before MD3 - Radio buttons have smaller touch targets than before MD3 - Slide toggles are same as before MD3, which happened to be a small touch target - Sliders have wider horizontal margins to allow to display the focus indicator in its entirety See also angular/components#27118
No description provided.