Skip to content

Conversation

@PowerKiKi
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades the codebase from PHP 8.2 to PHP 8.4, along with corresponding updates to PHPUnit, Doctrine ORM, and various dependencies. The upgrade includes modernization of test syntax, adoption of PHP 8.4 features, and removal of legacy configurations.

Key Changes:

  • PHP version upgraded to 8.4 across all configuration files and scripts
  • PHPUnit upgraded to version 10+ with migration to attribute-based data providers
  • Test mocking updated from createMock to createStub where expectations are not needed
  • PHP 8.4 typed constants added throughout the codebase
  • Doctrine ORM proxy generation configuration removed (lazy ghost objects support)

Reviewed changes

Copilot reviewed 55 out of 58 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
composer.json Updates PHP requirement to ^8.4 and upgrades dependencies including PHPUnit to @stable
phpunit.xml.dist Migrates to PHPUnit 10+ configuration with new cache directory structure
tests/**/*.php Converts @dataProvider annotations to #[DataProvider] attributes and makes providers static
tests/**/*.php Replaces createMock with createStub for test doubles that don't require expectations
server/**/*.php Adds typed constants (e.g., final public const string) for PHP 8.4
server/**/*.php Replaces trim() with mb_trim() for multibyte string handling
server/**/*.php Removes unnecessary parentheses around new object instantiation
config/**/*.php Updates PHP binary references from php8.2 to php8.4
config/autoload/doctrine.global.php Removes proxy generation configuration for Doctrine ORM 3.x compatibility
config/development.config.php.dist Removes proxy auto-generation configuration
bin/build.sh Removes orm:generate-proxies command and updates PHP version references
package.json, e2e/utils.ts, bin/dump-schema Updates PHP binary references to php8.4
.scrutinizer.yml Removes Scrutinizer CI configuration entirely
.github/workflows/main.yml Updates CI to PHP 8.4 and removes code coverage upload
README.md Removes Scrutinizer badges
phpstan-baseline.neon Adds suppressions for undefined $this in static closures workaround

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 55 out of 58 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@PowerKiKi PowerKiKi changed the title PHP 8.5 PHP 8.4 Dec 30, 2025
@PowerKiKi PowerKiKi merged commit 0929ac3 into master Dec 31, 2025
5 checks passed
@PowerKiKi PowerKiKi deleted the php85 branch December 31, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants