PHP 8.4 #74
Merged
PHP 8.4 #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it's been a very long time since it was useful for us. Code coverage statistics over time is the last interesting bit, but not worth the extra computing and maintenance cost.
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the project from PHP 8.2 to PHP 8.4 (note: the PR title says "PHP 8.5" but this appears to be an error as PHP 8.5 hasn't been released yet). The changes include:
- Upgrading PHP requirement from ^8.2 to ^8.4
- Adopting PHP 8.4 features like
mb_trim()and typed constants - Updating Doctrine ORM from 3.3 to 3.6 with native lazy objects support
- Updating GraphQL PHP library from 15.20 to 15.29
- Removing Scrutinizer CI integration
- Consolidating PHPUnit configuration options
- Updating all development dependencies to support PHP 8.4
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updates PHP requirement to ^8.4 and bumps major dependency versions |
| composer.lock | Reflects updated dependencies including Symfony 8.0, PHPUnit 12.x, and other dev tools |
| tests/EntityManagerTrait.php | Updates to use new Doctrine ORM API (createAttributeMetadataConfig) and enables native lazy objects |
| tests/DocBlockReaderTest.php | Adds typed constant declarations (PHP 8.3+ feature) |
| tests/Blog/Model/Post.php | Adds typed constant declarations for string constants |
| tests/Attribute/Reader/ReaderTest.php | Simplifies syntax by removing unnecessary parentheses |
| src/DocBlockReader.php | Replaces trim() with mb_trim() (PHP 8.4 native function) |
| src/Factory/Type/AbstractTypeFactory.php | Replaces trim() with mb_trim() |
| src/Factory/AbstractFactory.php | Replaces trim() with mb_trim() |
| phpunit.xml.dist | Consolidates multiple display detail options into single displayDetailsOnAllIssues option |
| phpstan-baseline.neon | Updates baseline with new PHPStan warnings from library updates |
| README.md | Removes Scrutinizer CI badges |
| .scrutinizer.yml | Removes Scrutinizer configuration file |
| .github/workflows/main.yml | Updates PHP version to 8.4 and removes code coverage job that uploaded to Scrutinizer |
| .gitattributes | Removes .scrutinizer.yml from export-ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.