Skip to content

Remove dead-code in theory cloning code. #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
strub merged 1 commit into from
Jan 7, 2026
Merged

Remove dead-code in theory cloning code. #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/ecThCloning.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ type evclone = {
evc_ops : (xop_override located) Msym.t;
evc_preds : (xpr_override located) Msym.t;
evc_abbrevs : (nt_override located) Msym.t;
evc_modexprs : (me_override located) Msym.t;
evc_modtypes : (mt_override located) Msym.t;
evc_lemmas : evlemma;
evc_ths : (evclone * bool) Msym.t;
Expand All @@ -93,7 +92,6 @@ let evc_empty =
evc_ops = Msym.empty;
evc_preds = Msym.empty;
evc_abbrevs = Msym.empty;
evc_modexprs = Msym.empty;
evc_modtypes = Msym.empty;
evc_lemmas = evl;
evc_ths = Msym.empty; }
Expand Down
1 change: 0 additions & 1 deletion src/ecThCloning.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ type evclone = {
evc_ops : (xop_override located) Msym.t;
evc_preds : (xpr_override located) Msym.t;
evc_abbrevs : (nt_override located) Msym.t;
evc_modexprs : (me_override located) Msym.t;
evc_modtypes : (mt_override located) Msym.t;
evc_lemmas : evlemma;
evc_ths : (evclone * bool) Msym.t;
Expand Down
53 changes: 5 additions & 48 deletions src/ecTheoryReplay.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,54 +868,11 @@ and replay_modtype
and replay_mod
(ove : _ ovrenv) (subst, ops, proofs, scope) (import, (me : top_module_expr))
=
match Msym.find_opt me.tme_expr.me_name ove.ovre_ovrd.evc_modexprs with
| None ->
let subst, name = rename ove subst (`Module, me.tme_expr.me_name) in
let me = EcSubst.subst_top_module subst me in
let me = { me with tme_expr = { me.tme_expr with me_name = name } } in
let item = (Th_module me) in
(subst, ops, proofs, ove.ovre_hooks.hadd_item scope ~import item)

| Some { pl_desc = (newname, mode) } ->
let name = me.tme_expr.me_name in
let env = EcSection.env (ove.ovre_hooks.henv scope) in

let mp, (newme, newlc) = EcEnv.Mod.lookup (unloc newname) env in

let substme = EcSubst.add_moddef subst ~src:(xpath ove name) ~dst:mp in

let me = EcSubst.subst_top_module substme me in
let me = { me with tme_expr = { me.tme_expr with me_name = name } } in
let newme = { newme with me_name = name } in
let newme = { tme_expr = newme; tme_loca = Option.get newlc; } in

if not (EcReduction.EqTest.for_mexpr ~body:false env me.tme_expr newme.tme_expr) then
clone_error env (CE_ModIncompatible (snd ove.ovre_prefix, name));

let subst =
match mode with
| `Alias ->
fst (rename ove subst (`Module, name))
| `Inline _ ->
substme in

let newme =
if mode = `Alias || mode = `Inline `Keep then
let alias = ME_Alias (
List.length newme.tme_expr.me_params,
EcPath.m_apply
mp
(List.map (fun (id, _) -> EcPath.mident id) newme.tme_expr.me_params)
)
in { newme with tme_expr = { newme.tme_expr with me_body = alias } }
else newme in

let scope =
if keep_of_mode mode
then ove.ovre_hooks.hadd_item scope ~import (Th_module newme)
else scope in

(subst, ops, proofs, scope)
let subst, name = rename ove subst (`Module, me.tme_expr.me_name) in
let me = EcSubst.subst_top_module subst me in
let me = { me with tme_expr = { me.tme_expr with me_name = name } } in
let item = (Th_module me) in
(subst, ops, proofs, ove.ovre_hooks.hadd_item scope ~import item)

(* -------------------------------------------------------------------- *)
and replay_export
Expand Down