feat: add proxy support to tid HTTP client #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add getHttpProxy() function to expose proxy configuration from http_pool - Update tid.nim to use proxy when creating AsyncHttpClient - Add debug logging statements in apiutils.nim and redis_cache.nim for troubleshooting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds proxy support to the tid HTTP client by exposing the proxy configuration and using it when creating HTTP clients.
Changes
getHttpProxy()function inhttp_pool.nimto expose the proxy configurationtid.nimto use the proxy when creatingAsyncHttpClientinstancesapiutils.nimandredis_cache.nimfor troubleshooting purposesMotivation
The tid HTTP client was not respecting the proxy configuration set via
setHttpProxy(), which could cause issues in environments where proxy usage is required.Testing
Related Issues