Skip to content

Silent code checker #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zhengyu123 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Silent code checker #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions ddprof-lib/src/main/cpp/libraryPatcher_linux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,9 @@ void LibraryPatcher::patch_libraries() {
void LibraryPatcher::patch_library_unlocked(CodeCache* lib) {
char path[PATH_MAX];
char* resolved_path = realpath(lib->name(), path);
if (resolved_path == nullptr) {
// virtual file, e.g. [vdso], etc.
// scan-build false positive: resolved_path is used at line 96
resolved_path = (char*)lib->name();
} else {
// Don't patch self
if (strcmp(resolved_path,_profiler_name) == 0) {
return;
}
if (resolved_path != nullptr && // filter out virtual file, e.g. [vdso], etc.
strcmp(resolved_path, _profiler_name) == 0) { // Don't patch self
return;
}

void** pthread_create_location = (void**)lib->findImport(im_pthread_create);
Expand Down
Loading