Send response headers on meta even without event#3653
Send response headers on meta even without event#3653estringana wants to merge 1 commit intomasterfrom
Conversation
|
✨ Fix all issues with BitsAI or with Cursor
|
Benchmarks [ appsec ]Benchmark execution time: 2026-02-17 10:36:22 Comparing candidate commit 929d678 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
0a92b8e to
1a708f7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3653 +/- ##
==========================================
- Coverage 62.21% 62.20% -0.02%
==========================================
Files 141 141
Lines 13387 13388 +1
Branches 1753 1753
==========================================
- Hits 8329 8328 -1
- Misses 4260 4263 +3
+ Partials 798 797 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
1a708f7 to
929d678
Compare
| Span span = trace.first() | ||
| assert span.metrics."_dd.appsec.enabled" == 1.0d | ||
| assert respContentType != null && respContentType.length() > 0 | ||
| assert span.meta."http.response.headers.content-type" == respContentType |
There was a problem hiding this comment.
You could test the other three as well. BTW the PR description says it's content-length and -type that we're adding, but -encoding and -language are sent as well. Is this the intended behavior?
Description
Extension should make sure that response
content-typeandcontent-lengthare always presents on span tags. Even without appsec eventsReviewer checklist