feat(tracer): add configuration for connection mode by Leiyks · Pull Request #3573 · DataDog/dd-trace-php

Leiyks · 2026-01-13T11:10:23Z

Description

Reviewer checklist

Test coverage seems ok.
Appropriate labels assigned.

datadog-official · 2026-01-13T13:17:21Z

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

ext/mysqli/tests/ghsa-h35g-vwh6-m678-stmt-row-bit.phpt (GHSA-h35g-vwh6-m678 (mysqlnd leaks partial content of the heap - stmt row bit buffer over-read))

from php.ext.mysqli.tests (Datadog) (Fix with Cursor)

--
     [*] Sending - Malicious Stmt Response for data bitval [Extract heap through buffer over-read]: 01000001023200000203646566087068705f74657374046461746104646174610673747276616c0673747276616c0ce000c8000000fd01100000003200000303646566087068705f74657374046461746104646174610662697476616c0662697476616c0c3f004000000010211000000005000004fe00002200100000050000067465737408080808080808080805000006fe00002200
     
013- [*] Received: 0500000019010000000100000001
013+ [*] Received: 050000001901000000
     [*] Server finished
     done!

🧪 1031 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6977985e000000007e40152a368a8123
tid: 6977985e00000000
hexProcessTraceId: 7e40152a368a8123
hexProcessSpanId: 038b08308412678b
processTraceId: 9097294518336258339
processSpanId: 255306808343816075

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: ec704d7 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

codecov-commenter · 2026-01-13T13:23:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.01%. Comparing base (4df27be) to head (ec704d7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3573      +/-   ##
==========================================
- Coverage   62.04%   62.01%   -0.04%     
==========================================
  Files         140      140              
  Lines       13312    13312              
  Branches     1762     1762              
==========================================
- Hits         8260     8255       -5     
- Misses       4262     4268       +6     
+ Partials      790      789       -1

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df27be...ec704d7. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pr-commenter · 2026-01-13T14:18:57Z

Benchmarks [ tracer ]

Benchmark execution time: 2026-01-26 17:22:50

Comparing candidate commit ec704d7 in PR branch leiyks/sidecar-threaded-fallback with baseline commit 4df27be in branch master.

Found 1 performance improvements and 6 performance regressions! Performance is the same for 187 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

🟩 execution_time [-1357.325ns; -442.675ns] or [-10.946%; -3.570%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

🟥 execution_time [+7.385µs; +8.175µs] or [+7.497%; +8.300%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

🟥 execution_time [+5.093µs; +7.027µs] or [+5.113%; +7.056%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

🟥 execution_time [+62.456ns; +122.144ns] or [+5.316%; +10.396%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

🟥 execution_time [+79.699ns; +151.301ns] or [+6.820%; +12.947%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

🟥 execution_time [+73.284ns; +119.316ns] or [+6.246%; +10.169%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

🟥 execution_time [+88.086ns; +147.514ns] or [+7.620%; +12.761%]

pr-commenter · 2026-01-14T14:56:48Z

Benchmarks [ profiler ]

Benchmark execution time: 2026-01-14 16:24:26

Comparing candidate commit 05ebcae in PR branch leiyks/sidecar-threaded-fallback with baseline commit 88a859c in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 28 metrics, 6 unstable metrics.

scenario:php-profiler-timeline-memory-with-profiler-and-timeline

🟥 cpu_user_time [+36.124ms; +78.620ms] or [+2.324%; +5.058%]
🟥 execution_time [+32.293ms; +51.335ms] or [+2.645%; +4.204%]

ext/ddtrace.c

ext/handlers_pcntl.c

tests/ext/sidecar_connection_mode_thread_phpfpm.phpt

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

bwoebi · 2026-02-17T18:30:32Z

components-rs/bytes.rs


 #[no_mangle]
-pub extern "C" fn ddog_set_span_service_zstr(ptr: &mut SpanBytes, str: &mut ZendString) {
+pub extern "C" fn ddog_set_span_service_zstr(ptr: &mut Span<BytesData>, str: &mut ZendString) {


Why this change?

bwoebi · 2026-02-17T18:54:59Z

ext/sidecar.c


    dd_sidecar_post_connect(&sidecar_transport, is_fork, logpath);

+    ddtrace_sidecar_reconnect(&sidecar_transport, dd_sidecar_connection_factory_thread);


I don't get this reconnect, I thought we just connected a couple lines above?

bwoebi · 2026-02-17T18:59:41Z

ext/sidecar.c

+        ddtrace_force_new_instance_id();
+
+        // Attempt to connect as a worker to parent's listener
+        ddtrace_sidecar = ddtrace_sidecar_connect_as_worker(true);


Shouldn't it just try, and fall back to creating a new master, if it didn't work?
I feel like you cheated around that with calling ddtrace_sidecar_reconnect inside ddtrace_sidecar_connect_as_worker ... but that's really weird :-D

bwoebi · 2026-02-17T19:02:25Z

ext/sidecar.c

+        ddtrace_force_new_instance_id();
+
+        if (ddtrace_sidecar) {
+            ddog_sidecar_transport_drop(ddtrace_sidecar);
+            ddtrace_sidecar = NULL;


This part should run independent of connection mode, right? ddtrace_sidecar merely holds the connection. (not the thread, which we must not drop)

Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch 4 times, most recently from ce20a9e to 2eb0609 Compare January 14, 2026 14:41

Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch 9 times, most recently from 06223eb to cda73e8 Compare January 16, 2026 15:24

bwoebi reviewed Jan 19, 2026

View reviewed changes

ext/ddtrace.c Outdated Show resolved Hide resolved

bwoebi reviewed Jan 19, 2026

View reviewed changes

ext/ddtrace.c Outdated Show resolved Hide resolved

bwoebi reviewed Jan 19, 2026

View reviewed changes

ext/handlers_pcntl.c Outdated Show resolved Hide resolved

bwoebi reviewed Jan 19, 2026

View reviewed changes

tests/ext/sidecar_connection_mode_thread_phpfpm.phpt Outdated Show resolved Hide resolved

Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch from 391826e to 2332634 Compare January 22, 2026 14:27

Leiyks added 7 commits January 22, 2026 16:05

feat(tracer): add configuration for connection mode

83076cf

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

feat(tracer): add sidecar thread listener module

820fa33

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

feat(tracer): implement threaded connection fallback

1238ce9

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

fix: compilation error

43eb2df

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

fix(tracer): remove debug logs

072962f

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

feat(tracer): add connection mode and function thread mode tests

fa88e71

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

feat(tracer): fix fork with thread mode

88442ce

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch from 2332634 to c59bfda Compare January 22, 2026 15:16

Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch 4 times, most recently from 53a9612 to ce80c19 Compare January 23, 2026 11:37

apply feedbacks

c31f9aa

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch 6 times, most recently from 8ffb585 to db23a4f Compare January 26, 2026 12:36

Leiyks marked this pull request as ready for review January 26, 2026 12:37

Leiyks requested review from a team as code owners January 26, 2026 12:37

Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch from db23a4f to 1dfbc13 Compare January 26, 2026 16:04

Leiyks requested a review from a team as a code owner January 26, 2026 16:04

feat(sidecar): support threaded connection for windows

ec704d7

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch from 1dfbc13 to ec704d7 Compare January 26, 2026 16:25

bwoebi reviewed Feb 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tracer): add configuration for connection mode#3573

feat(tracer): add configuration for connection mode#3573
Leiyks wants to merge 9 commits intomasterfrom
leiyks/sidecar-threaded-fallback

Leiyks commented Jan 13, 2026

Uh oh!

datadog-official bot commented Jan 13, 2026 •

edited by datadog-datadog-prod-us1 bot

Loading

Uh oh!

codecov-commenter commented Jan 13, 2026 •

edited

Loading

Uh oh!

pr-commenter bot commented Jan 13, 2026 •

edited

Loading

Uh oh!

pr-commenter bot commented Jan 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bwoebi Feb 17, 2026

Uh oh!

bwoebi Feb 17, 2026

Uh oh!

bwoebi Feb 17, 2026

Uh oh!

bwoebi Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		dd_sidecar_post_connect(&sidecar_transport, is_fork, logpath);

		ddtrace_sidecar_reconnect(&sidecar_transport, dd_sidecar_connection_factory_thread);

Conversation

Leiyks commented Jan 13, 2026

Description

Reviewer checklist

Uh oh!

datadog-official bot commented Jan 13, 2026 • edited by datadog-datadog-prod-us1 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

Uh oh!

codecov-commenter commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [ tracer ]

scenario:ComposerTelemetryBench/benchTelemetryParsing

scenario:MessagePackSerializationBench/benchMessagePackSerialization

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

scenario:SamplingRuleMatchingBench/benchRegexMatching1

scenario:SamplingRuleMatchingBench/benchRegexMatching2

scenario:SamplingRuleMatchingBench/benchRegexMatching3

scenario:SamplingRuleMatchingBench/benchRegexMatching4

Uh oh!

pr-commenter bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [ profiler ]

scenario:php-profiler-timeline-memory-with-profiler-and-timeline

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bwoebi Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

bwoebi Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

bwoebi Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

bwoebi Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

datadog-official bot commented Jan 13, 2026 •

edited by datadog-datadog-prod-us1 bot

Loading

codecov-commenter commented Jan 13, 2026 •

edited

Loading

pr-commenter bot commented Jan 13, 2026 •

edited

Loading

pr-commenter bot commented Jan 14, 2026 •

edited

Loading