Skip to content

Fix stopping too early #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nytra merged 2 commits into from
Oct 3, 2025
Merged

Fix stopping too early #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff5a84b
Fix it stopping too early
Nytra Oct 3, 2025
1beda1f
fix comment
Nytra Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 27 additions & 30 deletions ProjectObsidian.SourceGenerators/BindingGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,42 +317,39 @@ public override void VisitClassDeclaration(ClassDeclarationSyntax node)
_baseTypeNamespace = "FrooxEngine.FrooxEngine.ProtoFlux.";
}

if (!node.AttributeLists.Any())
if (node.AttributeLists.Any()) // if has any attributes
{
base.VisitClassDeclaration(node);
return;
}
// category
var nodeCategoryAttr = node.AttributeLists.SelectMany(i => i.Attributes)
.FirstOrDefault(i => i.Name.ToString() == "NodeCategory");

var find = node.AttributeLists.SelectMany(i => i.Attributes)
.FirstOrDefault(i => i.Name.ToString() == "NodeCategory");
if (nodeCategoryAttr?.ArgumentList is not null)
{
_category = nodeCategoryAttr.ArgumentList.Arguments.First().ToString().TrimEnds(1, 1);
}

_genericTypesAttribute = node.AttributeLists.FirstOrDefault(attrList => attrList.Attributes.Any(attr => attr.Name.ToString() == "GenericTypes"))?.ToString();
// generic types
_genericTypesAttribute = node.AttributeLists.FirstOrDefault(attrList => attrList.Attributes.Any(attr => attr.Name.ToString() == "GenericTypes"))?.ToString();

_oldTypeNameAttribute = node.AttributeLists.FirstOrDefault(attrList => attrList.Attributes.Any(attr => attr.Name.ToString() == "OldTypeName"))?.ToString();
// old type name
_oldTypeNameAttribute = node.AttributeLists.FirstOrDefault(attrList => attrList.Attributes.Any(attr => attr.Name.ToString() == "OldTypeName"))?.ToString();

if (find?.ArgumentList is null)
{
base.VisitClassDeclaration(node);
return;
}

_category = find.ArgumentList.Arguments.First().ToString().TrimEnds(1,1);

var findName = node.AttributeLists.SelectMany(i => i.Attributes)
.FirstOrDefault(i => i.Name.ToString() == "NodeName");
// name
var findName = node.AttributeLists.SelectMany(i => i.Attributes)
.FirstOrDefault(i => i.Name.ToString() == "NodeName");

if (findName?.ArgumentList != null)
_nodeNameOverride =
$" public override string NodeName => {findName.ArgumentList.Arguments.First().ToString()};";

if (findName?.ArgumentList != null)
_nodeNameOverride =
$" public override string NodeName => {findName.ArgumentList.Arguments.First().ToString()};";

var findOverload = node.AttributeLists.SelectMany(i => i.Attributes)
.FirstOrDefault(i => i.Name.ToString() == "NodeOverload");
// overload
var findOverload = node.AttributeLists.SelectMany(i => i.Attributes)
.FirstOrDefault(i => i.Name.ToString() == "NodeOverload");

if (findOverload?.ArgumentList != null)
_nodeOverloadAttribute = $"[Grouping({findOverload.ArgumentList.Arguments.First().ToString()})]";
}


if (findOverload?.ArgumentList != null)
_nodeOverloadAttribute = $"[Grouping({findOverload.ArgumentList.Arguments.First().ToString()})]";

foreach (var u in _usingDeclarations)
{
var fullNameSpace = "";
Expand All @@ -368,9 +365,9 @@ public override void VisitClassDeclaration(ClassDeclarationSyntax node)
_match = match;
_fullBaseType = fullNameSpace;
_valid = true;
base.VisitClassDeclaration(node);
return;
break;
}

base.VisitClassDeclaration(node);
}
}
Expand Down
Loading