Skip to content

fix issue 2 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Xlinka wants to merge 1 commit into from
Closed

fix issue 2 #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 44 additions & 34 deletions ProjectObsidian.SourceGenerators/BindingGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ public override void VisitUsingDirective(UsingDirectiveSyntax node)
}
public override void VisitClassDeclaration(ClassDeclarationSyntax node)
{
// Early exit, yeet it
if (node.BaseList is null)
{
base.VisitClassDeclaration(node);
Expand All @@ -297,53 +298,27 @@ public override void VisitClassDeclaration(ClassDeclarationSyntax node)

fullName += _additionalName;
}

BaseName = baseName;
_fullName = fullName;

if (node.ConstraintClauses.Any())
{
_constraints = node.ConstraintClauses.ToString();
}

var firstBaseType = node.BaseList.Types.First();
var baseTypeName = firstBaseType.Type.ToString();

_baseType = baseTypeName;
if (baseTypeName.Contains("ProxyVoidNode"))
{
_baseTypeNamespace = "FrooxEngine.FrooxEngine.ProtoFlux.";
}

if (!node.AttributeLists.Any())
{
base.VisitClassDeclaration(node);
return;
}

var find = node.AttributeLists.SelectMany(i => i.Attributes)
.FirstOrDefault(i => i.Name.ToString() == "NodeCategory");

_genericTypesAttribute = node.AttributeLists.FirstOrDefault(attrList => attrList.Attributes.Any(attr => attr.Name.ToString() == "GenericTypes"))?.ToString();

_oldTypeNameAttribute = node.AttributeLists.FirstOrDefault(attrList => attrList.Attributes.Any(attr => attr.Name.ToString() == "OldTypeName"))?.ToString();

if (find?.ArgumentList is null)
{
base.VisitClassDeclaration(node);
return;
}

_category = find.ArgumentList.Arguments.First().ToString().TrimEnds(1,1);

var findName = node.AttributeLists.SelectMany(i => i.Attributes)
.FirstOrDefault(i => i.Name.ToString() == "NodeName");


if (findName?.ArgumentList != null)
_nodeNameOverride =
$" public override string NodeName => {findName.ArgumentList.Arguments.First().ToString()};";

// Check if this class inherits from a valid node type
// This validation should happen regardless of attributes i hope
bool foundValidNodeType = false;
foreach (var u in _usingDeclarations)
{
var fullNameSpace = "";
Expand All @@ -355,13 +330,48 @@ public override void VisitClassDeclaration(ClassDeclarationSyntax node)
var match = ValidNodeTypes.FirstOrDefault(i => fullNameSpace.StartsWith(FluxPrefix + i));

if (match is null) continue;

_match = match;
_fullBaseType = fullNameSpace;
_valid = true;
foundValidNodeType = true;
break; // Found a valid node type dont bother checking further
}

if (!foundValidNodeType)
{
base.VisitClassDeclaration(node);
return;
}

// Process attributes if they exist
if (node.AttributeLists.Any())
{
var find = node.AttributeLists.SelectMany(i => i.Attributes)
.FirstOrDefault(i => i.Name.ToString() == "NodeCategory");

_genericTypesAttribute = node.AttributeLists.FirstOrDefault(attrList =>
attrList.Attributes.Any(attr => attr.Name.ToString() == "GenericTypes"))?.ToString();

_oldTypeNameAttribute = node.AttributeLists.FirstOrDefault(attrList =>
attrList.Attributes.Any(attr => attr.Name.ToString() == "OldTypeName"))?.ToString();

// Only process NodeCategory if it exists and has arguments
if (find?.ArgumentList is not null)
{
_category = find.ArgumentList.Arguments.First().ToString().TrimEnds(1, 1);
}

var findName = node.AttributeLists.SelectMany(i => i.Attributes)
.FirstOrDefault(i => i.Name.ToString() == "NodeName");

if (findName?.ArgumentList != null)
_nodeNameOverride =
$" public override string NodeName => {findName.ArgumentList.Arguments.First().ToString()};";
}

// Mark as valid since we found a valid node type
_valid = true;

base.VisitClassDeclaration(node);
}
}
Expand Down