Master into rails-6-1-compability #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loosen rails constraints to <6.1
Current versions are deprecated and will be unsupported by the end of the year. See: - https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ - https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
…l-and-setup-jira-sync-workflows Technical/REW-733 upgrade codeql and setup jira sync workflows
Rails 6.1 compatibility
Versions match what we're currently running.
> uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger
We use containers (rather than `setup-ruby`) since that's more representative of the environment in which we use the gem, even though it's presumably slower. Changes from Buildkite: - Use Docker healthcheck rather than waiting ourselves - Inline test script steps in workflows, rather than having a separate script (since we don't have the wait-for-MySQL part anymore) - Add GitHub-Actions-specific output grouping - Don't collect test failures via JUnit (it's overkill for the amount of tests we have).
Superseded by GitHub Actions workflow.
…actions Technical/REW-687 CI on GitHub Actions
Update rails constraints to 7.0
Fix autoloading for Rails 7.0
Enable gem configurables
Adds logic to ActiveStorageAdapter to handle uploading of CSV's (override file= method and save the uploaded tempfile using AS) Adds logic to parse AS uploaded file as CSV, handles byte order marking as users could still upload a file with a BOM. Moves out file_data method to each adapter Tweak check_file_contains_data method to check headers and count are present rather than checking data is inside csv (plays nicer with AS) Adds some temporary conditional logic to import table to show URL only if dragonfly (AS will be added at a later date) Adds StringEnquirer to storage_adapter config method
…sing spec failures)
…g ActiveStorage Integrity errors
Allow name of attachment to be dynamically set using config file
…ns-csv-uploads-on-the-admin-area Rew 2045 file upload restrictions csv uploads on the admin area
…over-ridden in MyRew) Correct typo
…ns-csv-uploads-on-the-admin-area REW-2045 - rename expiring_link method to download_link (can then be over-ridden in MyRew)
…is method on import table, this method can then be overwritten in file processor model's so custom logic can be added.
…ns-csv-uploads-on-the-admin-area REW-2045 - adds download_link method for dragonfly adapter
rjpaskin
approved these changes
Jul 21, 2025
reissjohnson
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Master into rails-6-1-compability