Skip to content

REW-2335 - Using url instead of service_url #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Albion31 merged 1 commit into from
Jul 21, 2025
Merged

REW-2335 - Using url instead of service_url #23

Albion31 merged 1 commit into from
Jul 21, 2025

Conversation

@Albion31
Copy link
Contributor

@Albion31 Albion31 commented Jul 21, 2025

Using url instead of service_url as service_url will be deprecated from rails 7.0

@Albion31 Albion31 self-assigned this Jul 21, 2025
@Albion31 Albion31 changed the base branch from master to rails-6-1-compatibility July 21, 2025 09:26
rjpaskin
rjpaskin previously approved these changes Jul 21, 2025
View reviewed changes
@reissjohnson reissjohnson changed the base branch from rails-6-1-compatibility to master July 21, 2025 09:37
@reissjohnson reissjohnson dismissed rjpaskin’s stale review July 21, 2025 09:37

The base branch was changed.

@reissjohnson reissjohnson changed the base branch from master to rails-6-1-compatibility July 21, 2025 09:38
@Albion31 Albion31 merged commit 9d4d34a into rails-6-1-compatibility Jul 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reissjohnson reissjohnson reissjohnson approved these changes

+1 more reviewer

@rjpaskin rjpaskin rjpaskin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Albion31 Albion31

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Albion31 @rjpaskin @reissjohnson