Implement dynamic discovery rows architecture#66
Closed
CollotsSpot wants to merge 5 commits intomasterfrom
Closed
Conversation
Instead of rendering multiple discovery shelves in a single MixesRow, each discovery folder now becomes its own row in the home screen, following the standard 237px height pattern. Changes: - Add RecommendationFolder model with polymorphic JSON parsing - Add DiscoveryRow widget for displaying a single discovery folder - Add discovery folders to MusicAssistantProvider (getDiscoveryFoldersWithCache) - Add discovery folders to CacheService and MusicAssistantAPI - Add "Discovery Mixes" toggle to settings (default off) - Update home screen to dynamically register discovery rows This fixes the architectural issue where MixesRow broke the home screen's assumption that each row entry renders exactly one row with a fixed height. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove references to non-existent RadioStation, Podcast, PodcastEpisode classes - Fix MediaType.podcastEpisode enum value (camelCase, not snake_case) - Use MediaItem base class for radio, podcast, podcast_episode types
…rror - Add import for RecommendationFolder model - Wrap firstWhere in try-catch to handle missing folders gracefully - Fixes the grey screen issue when discovery toggle is enabled Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
DiscoveryRow was using 52px for textAreaHeight vs AlbumRow's 44px, causing smaller artwork and different row appearance. Changed to 44px to match other rows. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…efresh - Move discovery mixes toggle from standalone to draggable row list in settings - Add empty state widget when no home screen rows are enabled - Fix pull-to-refresh not working when screen is empty by using SizedBox.expand - Add localization strings for empty state hint Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
Author
|
Closing to recreate after fixing CI issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of rendering multiple discovery shelves in a single MixesRow, each discovery folder now becomes its own row in the home screen, following the standard 237px height pattern.
Changes:
This fixes the architectural issue where MixesRow broke the home screen's assumption that each row entry renders exactly one row with a fixed height.