Skip to content

refactor(medcat-service): Demo app code improvements #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alhendrickson merged 10 commits into from
Feb 6, 2026
Merged

refactor(medcat-service): Demo app code improvements #317

alhendrickson merged 10 commits into from
Feb 6, 2026

Conversation

@alhendrickson
Copy link
Collaborator

@alhendrickson alhendrickson commented Feb 6, 2026 •
edited
Loading

Perform improvements from #279

  • Remove app from global scope
  • Add return types
  • Improve nesting in the interface construction
  • Mount the demo on "/", though disable by default with env var
  • Add tracing to the demo functions

@alhendrickson alhendrickson marked this pull request as ready for review February 6, 2026 14:38
mart-r
mart-r approved these changes Feb 6, 2026
View reviewed changes
Copy link
Collaborator

@mart-r mart-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

Looks great to me! As long as the atual app didn't suffer, of course!

@alhendrickson alhendrickson merged commit 4a70b3a into main Feb 6, 2026
11 checks passed
@alhendrickson alhendrickson deleted the refactor/medcat-service/improve-demo branch February 6, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mart-r mart-r mart-r approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alhendrickson @mart-r