-
Notifications
You must be signed in to change notification settings - Fork 4
Send attribution Id to native SDK #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/google_maps_flutter/google_maps_flutter_ios/example/ios14/ios/Podfile
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/android/build.gradle
Outdated
Show resolved
Hide resolved
| [GMSServices provideAPIKey:mapsApiKey]; | ||
|
|
||
| NSString *attributionId = [NSString stringWithFormat:@"gmp_flutter_googlemapsflutter_v%sandroid", PREFIX_PLUGIN_VERSION]; | ||
| [GMSServices addInternalUsageAttributionID:attributionId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example app is not right place to do this. We need to do this somehow on the package code.
As devs can easily left this out.
Maybe we need to do this on first map view initialization (if not done yet)?
Or if it is possible to detect that key is given for GMSServices somehow.
Let's ask Caio / and their team what they think of that.
This means that applications do not report the package usage, unless map is shown on the app. (which sounds right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be done here:
https://github.com/CodemateLtd/packages/blob/main/packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FLTGoogleMapsPlugin.m#L12
Please check if this is called always after AppDelegate is completed; I suppose it is, but let's be sure. Then we can be sure the provideApiKey is always called before running the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the code to use selector for this call but it seems to be called in this order:
FLTGoogleMapPluginAppDelegate
Is there a problem with this? The reference doesn't say it should be called after map API key is set
packages/google_maps_flutter/google_maps_flutter_ios/ios/google_maps_flutter_ios.podspec
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/version_check.yaml
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_web/version_check.yaml
Outdated
Show resolved
Hide resolved
|
Will create a new clean PR |
First draft of attributionId call:
version_check.yamland a set of new tools to check if package's version matches the version in the native layer (java (Android), .h (iOS), .dart (web))