This repository was archived by the owner on Apr 15, 2021. It is now read-only.
Updates JS to allow YouTube URL Parameters#40
Open
taylordaughtry wants to merge 1 commit intoCodeinwp:masterfrom
taylordaughtry:master
Open
Updates JS to allow YouTube URL Parameters#40taylordaughtry wants to merge 1 commit intoCodeinwp:masterfrom taylordaughtry:master
taylordaughtry wants to merge 1 commit intoCodeinwp:masterfrom
taylordaughtry:master
Conversation
Author
There was a problem hiding this comment.
This updates the checkContent to make sure it's okay with the additional URL parameters...
|
With the changes applied above, instead of the YouTube link opening in lightbox, it now redirects to the corresponding YouTube page? I rechecked the code and all is where it should be. Just to clarify. Here's a href in my page; Open Lightbox with YT Movie Inside When I click this in the browser, it takes me directly to; https://www.youtube.com/watch?v=tQ31O6YGdxM&feature=youtu.be&rel=0 So, the URL is changed completely. |
|
The current code doesn't resolve this issue. Any suggestions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current JS strips the URL parameters from the YouTube link with RegEx. I updated the RegEx (and associated code) to store the parameters with the video array, and use them as appropriate in the Javascript.
This fixes issues #33 and #25