T32139 default negative ids for new models#112
Open
robinzelders wants to merge 54 commits intoCodeYellowBV:health_masterfrom
Open
T32139 default negative ids for new models#112robinzelders wants to merge 54 commits intoCodeYellowBV:health_masterfrom
robinzelders wants to merge 54 commits intoCodeYellowBV:health_masterfrom
Conversation
…s-for-new-models # Conflicts: # package.json
…ew-for-negative-ids
…s-for-new-models # Conflicts: # package.json Ref T32139
Ref T32139
daanvdk
suggested changes
Jul 26, 2021
abzainuddin
requested changes
Jul 26, 2021
Contributor
abzainuddin
left a comment
abzainuddin
left a comment
There was a problem hiding this comment.
TODO:
- Fix small typo
- Add documentation about when negative ids are supplied, and what now
nullmeans, and when isNew return true
dist/mobx-spine.cjs.js
Outdated
| /** | ||
| * A model is considered new if it does not have an id, or if the id is a negative integer. | ||
| * @returns {boolean} True if the model id is not set or a negative integer | ||
| * @returns {boolean} - True if the model id is not set or a negative integer |
Ref T32139
Files in request body
…t-body Automatically convert files in data to the format understood by django binder
ref T34782
T34782 relations error
…ing a project to use negative ids Ref T32139
…-models # Conflicts: # src/Model.js Ref T32139
Ref T32139
…egative-ids-for-new-models # Conflicts: # dist/mobx-spine.cjs.js # dist/mobx-spine.es.js # package.json # src/__tests__/Model.js Ref T32139
…g_bug Fix with sorting bug
…egative-ids-for-new-models # Conflicts: # src/__tests__/Model.js Ref T32139
Ref T32139
Codecov Report
@@ Coverage Diff @@
## health_master #112 +/- ##
=================================================
+ Coverage 93.38% 93.59% +0.20%
=================================================
Files 5 5
Lines 862 843 -19
Branches 206 200 -6
=================================================
- Hits 805 789 -16
+ Misses 47 44 -3
Partials 10 10
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes mobx-spine to automatically set negative ids for new models, it will also create a new negative id on every clear