perf(executor): Optimise topological sort from O(n²) to O(n+e)#12
Merged
CodeWithBehnam merged 1 commit intomainfrom Dec 25, 2025
Merged
perf(executor): Optimise topological sort from O(n²) to O(n+e)#12CodeWithBehnam merged 1 commit intomainfrom
CodeWithBehnam merged 1 commit intomainfrom
Conversation
- Add reverse adjacency list (dependents map) for O(1) dependent lookup - Add nodeById map for O(1) node access by ID - Eliminate nested loop that scanned all nodes for each processed node - Complexity now O(n + e) where n = nodes, e = edges Co-Authored-By: Behnam & Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimise the graph traversal algorithm in the execution engine from O(n²) to O(n+e) complexity.
Problem
The original Kahn's algorithm implementation had a nested loop that scanned all nodes to find dependents:
```typescript
// O(n) for each node processed = O(n²) total
for (const otherNode of nodes) {
if (dependencies.get(otherNode.id)?.has(node.id)) {
// ...
}
}
```
Solution
Build a reverse adjacency list (dependents map) during the initial graph scan, enabling O(1) lookup:
```typescript
// O(1) lookup of nodes that depend on this one
const nodeDependents = dependents.get(node.id)
for (const dependentId of nodeDependents) {
// ...
}
```
Complexity Analysis
Changes
dependentsmap (reverse adjacency list)nodeByIdmap for O(1) node lookup by IDBehnam Ebrahimi