Skip to content

[iOS] Add ProgressBar component #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pnalvarez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[iOS] Add ProgressBar component #75

pnalvarez wants to merge 1 commit into from

Conversation

@pnalvarez
Copy link

@pnalvarez pnalvarez commented Nov 18, 2025

Description

This PR adds a new CraftDProgressBar component with a serialized data model as input and displays in the sample list.

Tests

Added component in the sample list and an input in the dynamic.json file

Screenshots

Simulator Screen Recording - iPhone 17 Pro Max - 2025-11-17 at 22 43 39

Check list

  • The tests were executed and passed successfully.
  • Code changes follow the project style guidelines.
  • Tests have been added if applicable.
  • Did you subscribe to the channel?😛

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Warnings Elapsed time
⚠️ KOTLIN detekt yes 93 no 3.51s
⚠️ MARKDOWN markdown-table-formatter 19 1 0 0.34s
✅ YAML prettier 15 0 0 0.91s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

gabrielbmoro
gabrielbmoro requested changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@gabrielbmoro gabrielbmoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it worth remove unnecessary files, and including them in our .gitignore

android_kmp/app-sample/.idea/caches/deviceStreaming.xml
Copy link
Collaborator

@gabrielbmoro gabrielbmoro Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#question
Can you remove this file? It is not necessary

android_kmp/app-sample/.idea/gradle.xml
Copy link
Collaborator

@gabrielbmoro gabrielbmoro Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#question
Can you remove this file? It is not necessary

android_kmp/app-sample/.idea/migrations.xml
Copy link
Collaborator

@gabrielbmoro gabrielbmoro Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#question
Can you remove this file? It is not necessary

android_kmp/app-sample/.idea/misc.xml
Copy link
Collaborator

@gabrielbmoro gabrielbmoro Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#question
Can you remove this file? It is not necessary

android_kmp/app-sample/.idea/runConfigurations.xml
Copy link
Collaborator

@gabrielbmoro gabrielbmoro Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#question
Can you remove this file? It is not necessary

android_kmp/app-sample/.idea/workspace.xml
Copy link
Collaborator

@gabrielbmoro gabrielbmoro Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#question
Can you remove this file? It is not necessary

ios/craftd-swiftui/Sources/craftd-swiftui/presentation/ui/progressBar/CraftDProgressBar.swift
self.progress = properties.progress ?? 0.0
self.height = CGFloat(properties.height ?? 0.0)
self.alignment = properties.alignment ?? .top
self.textColor = properties.textColor ?? "#000000"
Copy link
Collaborator

@gabrielbmoro gabrielbmoro Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#question
Can we create a constant to represent default values for example, here we can have one called Color.Unspecified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielbmoro gabrielbmoro gabrielbmoro requested changes

@rviannaoliveira rviannaoliveira Awaiting requested review from rviannaoliveira rviannaoliveira is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pnalvarez @gabrielbmoro @rviannaoliveira