Skip to content

Conversation

@AddisonSchiller
Copy link
Contributor

Ticket

https://openscience.atlassian.net/browse/SVCS-541

Purpose

Remove lines stopping callbacks for download_file/zip.
This PR currently has a blocker.
https://openscience.atlassian.net/browse/OSF-8785 Needs to go through before this can go through.

Changes

Removed lines stopping logs from going through

Side effects

This is currently blocked by : https://openscience.atlassian.net/browse/OSF-8785
There is a lot of log spam/spam in general that will happen if OSF-8785 does not go through before this one.

QA Notes

Deployment Notes

@coveralls
Copy link

coveralls commented Oct 16, 2017

Coverage Status

Coverage increased (+0.06%) to 89.071% when pulling ef634a1 on AddisonSchiller:feature/svcs-541-callback-logs into 481c9d9 on CenterForOpenScience:develop.

Copy link
Member

@TomBaxter TomBaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve removing both the belt and the suspenders.

@TomBaxter
Copy link
Member

@cslzchen This is ready for next round of review.

@cslzchen
Copy link
Contributor

@TomBaxter thanks bunches!

Copy link
Contributor

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

This PR is closely related to and blocked by #277. Please double check after the blocker is merged. Below is the comments I have for the blocker:

  • Add/update tests (if necessary)
  • Add a # TODO in the code and/or a note in the PR/Ticket indicating what/Where needs to be updated for this to take effect.
  • Check with DjangoLE team to see if this is what they want and they know what to do with OSF side.

@felliott A question for you, is it better to combine the two PRs into one given that we probably need to recreate PRs for them.

@coveralls
Copy link

coveralls commented Dec 11, 2017

Coverage Status

Coverage increased (+0.05%) to 89.829% when pulling 053e11c on AddisonSchiller:feature/svcs-541-callback-logs into 6249a7a on CenterForOpenScience:develop.

@cslzchen cslzchen changed the title [SVCS-541][BLOCKED] Allow WB to log download_file/zip [SVCS-541] [Blocked] Allow WB to log download_file/zip Dec 11, 2017
@felliott
Copy link
Member

@cslzchen, no, as similar as these two are they should remain separate for now. They serve different goals. This one is for counting downloads, and the needed OSF-side work is being done by B&I. The other is for changing how we track metadata, and the needed OSF-side work is being done by DLE. We will need to resolve the conflicts once they're in, but I don't know which is going to land first.

@cslzchen
Copy link
Contributor

@felliott Agreed. I think either can go first since there is no blocking relationship but only merge conflicts due to the same part of code being modified.

@cslzchen cslzchen changed the title [SVCS-541] [Blocked] Allow WB to log download_file/zip [SVCS-541] Allow WB to log download_file/zip Jan 3, 2018
@cslzchen
Copy link
Contributor

cslzchen commented Jan 3, 2018

For whoever takes this ticket: another ticket SVCS-475 with PR-307 has passed code review. If merged, there will be conflicts.

@felliott
Copy link
Member

felliott commented Feb 6, 2018

This looks good as-is. The Platforms team is ready for this to go in, so merging. No need to fix the conflicts in #307 right now, we'll worry about when we get closer. Merging!

@felliott felliott closed this in 6dae478 Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants