Skip to content

[ENG-9727] unable to create new version of a preprint when registration field has content #11492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkovalua wants to merge 1 commit into
base: feature/pbs-25-25
Choose a base branch
from
+2 −1
Open

[ENG-9727] unable to create new version of a preprint when registration field has content #11492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/preprints/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ def update(self, preprint, validated_data):

updated_has_prereg_links = validated_data.get('has_prereg_links', preprint.has_prereg_links)
updated_why_no_prereg = validated_data.get('why_no_prereg', preprint.why_no_prereg)
prereg_links = validated_data.get('prereg_links', preprint.prereg_links)

if updated_has_coi is False and updated_conflict_statement:
raise exceptions.ValidationError(
Expand All @@ -341,7 +342,7 @@ def update(self, preprint, validated_data):
detail='Cannot provide data links when has_data_links is set to "no".',
)

if updated_has_prereg_links != 'no' and updated_why_no_prereg:
if updated_has_prereg_links != 'no' and (updated_why_no_prereg and not prereg_links):
raise exceptions.ValidationError(
detail='You cannot edit this statement while your prereg links availability is set to true or is unanswered.',
)
Expand Down
Loading