Skip to content

[ENG-8524] Update permissions for write preprint contributors #11272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vlad0n20 wants to merge 2 commits into
base: feature/pbs-25-25
Choose a base branch
from
Open

[ENG-8524] Update permissions for write preprint contributors #11272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f72790b
Update permissions for write preprint contributors
Vlad0n20 Aug 28, 2025
b87ceb7
Remove duplicate code
Vlad0n20 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions api/actions/permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,20 @@ def has_object_permission(self, request, view, obj):
else:
# Moderators and node admins can trigger state changes.
is_node_admin = target is not None and target.has_permission(auth.user, osf_permissions.ADMIN)
if not (is_node_admin or auth.user.has_perm('view_submissions', provider)):
return False
is_write_contributor = target is not None and target.has_permission(auth.user, osf_permissions.WRITE)

# User can trigger state changes on this reviewable, but can they use this trigger in particular?
# Validate serializer once and extract trigger
serializer = view.get_serializer(data=request.data)
serializer.is_valid(raise_exception=True)
trigger = serializer.validated_data.get('trigger')

provisional_write_allowed = is_write_contributor and trigger == ReviewTriggers.SUBMIT.value

if not (is_node_admin or auth.user.has_perm('view_submissions', provider) or provisional_write_allowed):
return False

# User can trigger state changes on this reviewable, but can they use this trigger in particular?
permission = TRIGGER_PERMISSIONS[trigger]
if permission is None and is_write_contributor and trigger == ReviewTriggers.SUBMIT.value:
return True
return permission is None or request.user.has_perm(permission, target.provider)
Loading