Skip to content

fix: Detailed path cursor doesn't work on paths with holes #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StickmanRed wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix: Detailed path cursor doesn't work on paths with holes #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion engine/src/tools/PathCursor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,12 @@ Wick.Tools.PathCursor = class extends Wick.Tool {
if(!newHitResult) newHitResult = new this.paper.HitResult();

if (this.detailedEditing !== null) {
if (this._getWickUUID(newHitResult.item) !== this._getWickUUID(this.detailedEditing)) {
// Bugfix: newHitResult.item might be inside a CompoundPath
var targetItem = newHitResult.item;
if (targetItem && targetItem.parent.className === 'CompoundPath') {
targetItem = targetItem.parent;
}
if (this._getWickUUID(targetItem) !== this._getWickUUID(this.detailedEditing)) {
// Hits an item, but not the one currently in detail edit - handle as a click with no hit.
return new this.paper.HitResult();
}
Expand Down