feat(algorithms, intervals, flowers bloom): full bloom flowers #129
Conversation
BrianLusina
added
enhancement
Algorithm
📝 WalkthroughWalkthroughThe PR introduces a new problem solution "Number of Flowers in Full Bloom" with binary search–based implementations, adds an alternative merge-based approach to the count_days algorithm, and provides comprehensive documentation and test coverage for the new module. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
algorithms/intervals/count_days/__init__.py (1)
73-88: Remove duplicate code.Lines 73–78 duplicate the logic that begins at line 80, including redundant sorts and variable initializations. This leftover code should be removed.
🔎 Proposed fix
- # Sort the meetings based on their start time to process them in order - meetings.sort() - - # Initialize a variable with 0 to count the number of days when the employee has meetings scheduled - occupied = 0 - # Initialize two variables with the first meeting's start and end times # Sort the meetings based on their start time to process them in order meetings.sort()
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
DIRECTORY.mdalgorithms/intervals/count_days/__init__.pyalgorithms/intervals/full_bloom_flowers/README.mdalgorithms/intervals/full_bloom_flowers/__init__.pyalgorithms/intervals/full_bloom_flowers/test_full_bloom_flowers.py
🧰 Additional context used
🧬 Code graph analysis (1)
algorithms/intervals/full_bloom_flowers/test_full_bloom_flowers.py (1)
algorithms/intervals/full_bloom_flowers/__init__.py (2)
full_bloom_flowers(5-29)full_bloom_flowers_2(32-49)
🪛 markdownlint-cli2 (0.18.1)
DIRECTORY.md
106-106: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
107-107: Unordered list indentation
Expected: 4; Actual: 6
(MD007, ul-indent)
🔇 Additional comments (3)
algorithms/intervals/full_bloom_flowers/README.md (1)
1-62: Excellent documentation!The README provides a clear problem description, well-explained solution approach with step-by-step breakdown, and accurate complexity analysis. This will help future developers understand the algorithm.
algorithms/intervals/full_bloom_flowers/__init__.py (2)
5-29: LGTM!The implementation correctly uses
bisect_rightto count flowers that started at or before the arrival time andbisect_leftto count flowers that ended strictly before arrival. The logic is sound and well-documented.
32-49: LGTM!The alternative implementation using
end + 1adjustment is clever and correct. By shifting the end boundary, both binary searches can consistently usebisect_right. The result matches the first implementation's behavior.
| def test_full_bloom_flowers( | ||
| self, flowers: List[List[int]], people: List[int], expected: List[int] | ||
| ): | ||
| actual = full_bloom_flowers_2(flowers, people) | ||
| self.assertEqual(expected, actual) |
There was a problem hiding this comment.
Rename the duplicate test method.
The second test method has the same name as the first (line 20), which causes Python to override the first definition. This means full_bloom_flowers is never tested—only full_bloom_flowers_2 runs.
🔎 Proposed fix
@parameterized.expand(TEST_CASES)
- def test_full_bloom_flowers(
+ def test_full_bloom_flowers_2(
self, flowers: List[List[int]], people: List[int], expected: List[int]
):
actual = full_bloom_flowers_2(flowers, people)
self.assertEqual(expected, actual)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| def test_full_bloom_flowers( | |
| self, flowers: List[List[int]], people: List[int], expected: List[int] | |
| ): | |
| actual = full_bloom_flowers_2(flowers, people) | |
| self.assertEqual(expected, actual) | |
| def test_full_bloom_flowers_2( | |
| self, flowers: List[List[int]], people: List[int], expected: List[int] | |
| ): | |
| actual = full_bloom_flowers_2(flowers, people) | |
| self.assertEqual(expected, actual) |
🤖 Prompt for AI Agents
In algorithms/intervals/full_bloom_flowers/test_full_bloom_flowers.py around
lines 27 to 31 (and noting the duplicate at line 20), the second test method
reuses the same name as the first causing the first to be overridden; rename
this second test method to a unique name (for example test_full_bloom_flowers_2
or test_full_bloom_flowers_variant) so both implementations are executed, and
update any references or parametrization decorators accordingly to reflect the
new name.
Describe your change:
Flowers in full bloom on people's arrivals
Checklist:
Fixes: #{$ISSUE_NO}.Summary by CodeRabbit
New Features
Documentation
Tests
✏️ Tip: You can customize this high-level summary in your review settings.