Move change calculation into separate reducer #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the change detection logic by moving it from the experimentReducer into a separate calculateChangeReducer, addressing a race condition where changes were not detected when a datapoint transitioned from invalid to valid state.
Changes:
- Extracted change calculation logic into a dedicated reducer
- Applied the new reducer after validation to ensure changes are detected post-validation
- Added comprehensive test coverage for the new reducer
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/context/experiment/reducers.ts | Imports and applies the new calculateChangeReducer after validation |
| packages/core/src/context/experiment/reducers.test.ts | Adds test assertion to verify hash calculation consistency |
| packages/core/src/context/experiment/experiment-reducers.ts | Removes the change calculation logic from the main experiment reducer |
| packages/core/src/context/experiment/calculate-change-reducer.ts | New file containing the extracted change calculation logic |
| packages/core/src/context/experiment/calculate-change-reducer.test.ts | Comprehensive test suite for the new reducer |
| .changeset/silent-feet-breathe.md | Documents the fix for the race condition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
langdal
force-pushed
the
reducer-change-calculation
branch
from
6b95eba to
3eae3d3
Compare
j-or
approved these changes
Jan 23, 2026
langdal
force-pushed
the
reducer-change-calculation
branch
from
3eae3d3 to
bb86856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.