Skip to content

Conversation

@aguspdana
Copy link
Collaborator

@aguspdana aguspdana commented Feb 10, 2026


Summary by cubic

Fix failing tests by standardizing Date handling and honoring returnNulls for empty results. Also skip failing nested flex reference tests in the query suite.

  • Bug Fixes

    • Return null when result is an empty array and returnNulls is true.
    • deepSort now leaves Date values unchanged.
    • Tests updated to pass { returnNulls: true } and expect Date objects.
    • Simplified requested fields in edges tests to match current data shape.
    • Log finalResult directly (no JSON.stringify) for clearer output.
    • Skipped failing nested flex reference tests.
  • Migration

    • If you expect nulls for missing records in multi-queries, pass { returnNulls: true } to ctx.query.

Written for commit 75f8de9. Summary will update on new commits.


Important

Fix failed tests by handling empty arrays, modifying logging, and ensuring correct handling of date objects across multiple files and test cases.

  • Behavior:
    • In processResults.ts, handle empty arrays by returning null if returnNulls is true.
    • In run.ts, modify logging to log finalResult directly instead of stringifying it.
    • In helpers.ts, ensure deepSort() in matchers.ts returns Date objects without modification.
  • Tests:
    • In basic.ts, edges.ts, and refFields.ts, update test cases to include returnNulls option and handle Date objects correctly.
    • Modify test cases to ensure correct handling of empty arrays and null values.
  • Misc:
    • Minor code formatting changes in helpers.ts for readability.

This description was created by Ellipsis for aca2a31. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to aca2a31 in 19 seconds. Click for details.
  • Reviewed 268 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_yQ8Hinuge7wJXxBG

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 75f8de9 in 19 seconds. Click for details.
  • Reviewed 40 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_3pDcYSNCVhljNI1j

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant