Skip to content

maintenance: expose Info method. #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bznein merged 1 commit into from
Sep 18, 2025
Merged

maintenance: expose Info method. #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions api/firmware/device.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,14 +170,13 @@ func NewDevice(
}
}

// info uses the opInfo api endpoint to learn about the version, platform/edition, and unlock
// Info uses the opInfo api endpoint to learn about the version, platform/edition, and unlock
// status (true if unlocked).
func (device *Device) info() (*semver.SemVer, common.Product, bool, error) {

func Info(communication Communication) (*semver.SemVer, common.Product, bool, error) {
// CAREFUL: hwwInfo is called on the raw transport, not on device.rawQuery, which behaves
// differently depending on the firmware version. Reason: the version is not
// available (this call is used to get the version), so it must work for all firmware versions.
response, err := device.communication.Query([]byte(hwwInfo))
response, err := communication.Query([]byte(hwwInfo))
if err != nil {
return nil, "", false, err
}
Expand Down Expand Up @@ -227,6 +226,10 @@ func (device *Device) info() (*semver.SemVer, common.Product, bool, error) {
return version, product, unlocked, nil
}

func (device *Device) info() (*semver.SemVer, common.Product, bool, error) {
return Info(device.communication)
}

// Version returns the firmware version.
func (device *Device) Version() *semver.SemVer {
if device.version == nil {
Expand Down
Loading