Conversation
AARON-CLARK
left a comment
AARON-CLARK
left a comment
There was a problem hiding this comment.
@Jeff-Thompson12 Look good. I made a few minor comments below.
| #' @import shiny | ||
| #' @import dplyr | ||
| #' @importFrom IDEAFilter shiny_data_filter | ||
| #' @importFrom IDEAFilter shiny_data_filter IDEAFilter |
There was a problem hiding this comment.
is shiny_data_filter still required?
| #' @importFrom IDEAFilter shiny_data_filter IDEAFilter | |
| #' @importFrom IDEAFilter IDEAFilter |
| #' @import shiny | ||
| #' @importFrom shinyjs useShinyjs hidden | ||
| #' @importFrom IDEAFilter shiny_data_filter_ui | ||
| #' @importFrom IDEAFilter shiny_data_filter_ui IDEAFilter_ui |
There was a problem hiding this comment.
Is shiny_data_filter_ui still required?
| #' @importFrom IDEAFilter shiny_data_filter_ui IDEAFilter_ui | |
| #' @importFrom IDEAFilter IDEAFilter_ui |
| #' @import shiny | ||
| #' @importFrom plotly plotlyOutput | ||
| #' @importFrom IDEAFilter shiny_data_filter_ui | ||
| #' @importFrom IDEAFilter shiny_data_filter_ui IDEAFilter_ui |
There was a problem hiding this comment.
Is shiny_data_filter_ui still required?
| #' @importFrom IDEAFilter shiny_data_filter_ui IDEAFilter_ui | |
| #' @importFrom IDEAFilter IDEAFilter_ui |
| #' | ||
| #' @import shiny | ||
| #' @importFrom IDEAFilter shiny_data_filter_ui | ||
| #' @importFrom IDEAFilter shiny_data_filter_ui IDEAFilter_ui |
There was a problem hiding this comment.
Is shiny_data_filter_ui still required?
| #' @importFrom IDEAFilter shiny_data_filter_ui IDEAFilter_ui | |
| #' @importFrom IDEAFilter IDEAFilter_ui |
| #' @import shiny | ||
| #' @import dplyr | ||
| #' @importFrom IDEAFilter shiny_data_filter | ||
| #' @importFrom IDEAFilter shiny_data_filter IDEAFilter |
There was a problem hiding this comment.
is shiny_data_filter still required?
| #' @importFrom IDEAFilter shiny_data_filter IDEAFilter | |
| #' @importFrom IDEAFilter IDEAFilter |
| #' @param filePaths NULL | ||
| #' | ||
| #' @importFrom IDEAFilter shiny_data_filter | ||
| #' @importFrom IDEAFilter shiny_data_filter IDEAFilter |
There was a problem hiding this comment.
is shiny_data_filter still required?
| #' @importFrom IDEAFilter shiny_data_filter IDEAFilter | |
| #' @importFrom IDEAFilter IDEAFilter |
|
@AARON-CLARK the answer to all the above is "No". I set this branch up as an easy way to see the new look and performance of the improved |
Codecov Report
@@ Coverage Diff @@
## devel #247 +/- ##
==========================================
+ Coverage 19.26% 23.35% +4.08%
==========================================
Files 54 56 +2
Lines 4771 5036 +265
==========================================
+ Hits 919 1176 +257
- Misses 3852 3860 +8
|
2 participants
Corresponding to: https://github.com/Biogen-Inc/IDEAFilter/pull/18/files
With new additions to
NEWSfile:datetimevectors (adding across to uploaded data and raw datasets #17)IDEAFilter()that uses a more modern implementation and less resources (Have github icon link to tidyCDISC repo #22)pillar::new_pillar_type()topillar::type_sum()(Batch Download: Automatically adjust the size of the watermark #9)