-
Notifications
You must be signed in to change notification settings - Fork 0
investigating separating out documents from the rest of the message h… #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
anarchivist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting work - i'm excited to see this proceeding.
9cce4d4 to
e999fa8
Compare
326d731 to
ea41942
Compare
…istory and instructions.
- this gets cohere specific response field that includes citations for the response text
- temporarily add raw citations to response.
ea41942 to
595169c
Compare
awilfox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good and I'm glad to see this. It feels like the beginning of cleaning up Graph Manager to be more coherent (no pun intended) and easier to follow.
A few nits, and a single question. After those are handled, r+ from me.
... suggestions from @awilfox
aaarrrrgghghghghg
anarchivist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of questions around error handling and typing, but largely looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the chatbot's graph workflow to separate document retrieval from message preparation, introducing a clearer separation of concerns between context retrieval and response generation.
Key Changes:
- Introduced a new workflow node
prepare_for_generationto separate message preparation from response generation - Replaced the
docs_contextstring-based approach with structureddocumentslist containing metadata - Modified the prompt system to no longer inject context directly into the system message, instead passing documents via
additional_model_request_fields
awilfox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not tested locally yet, but looks good to me. Thank you for splitting it off the other changes and tidying it up! ![]()
anarchivist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just confirming that i have tested this locally and it's ready to go 🚀
…istory and instructions.