Skip to content

Conversation

@1RyanK
Copy link
Collaborator

@1RyanK 1RyanK commented Dec 15, 2025

In order to test performance in PR #5090 I thought it would be good to have a benchmark. This sets up the framework, and then in that PR I will modify the benchmark to include the new function introduced there.

Closes #5159: Create a benchmark for uniquely concatenating strings

@1RyanK 1RyanK marked this pull request as ready for review December 15, 2025 15:33
Copy link
Contributor

@ajpotts ajpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@drculhane drculhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward.

Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ajpotts ajpotts added this pull request to the merge queue Dec 17, 2025
Merged via the queue into Bears-R-Us:main with commit aa5e8ab Dec 17, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a benchmark for uniquely concatenating strings

4 participants