Preview version of Collada Transcoder#31
Draft
pandaGaume wants to merge 39 commits intoBabylonJS:masterfrom
Draft
Preview version of Collada Transcoder#31pandaGaume wants to merge 39 commits intoBabylonJS:masterfrom
pandaGaume wants to merge 39 commits intoBabylonJS:masterfrom
Conversation
|
|
PolygonalSun
reviewed
Jun 8, 2020
| @@ -1254,6 +1281,8 @@ void ProcessLODs( | |||
| options); | |||
| } | |||
|
|
|||
PolygonalSun
reviewed
Jun 8, 2020
| inline size_t Babylon::Transcoder::TranscoderTextStream::ReadFully_s(char* outputBuffer, size_t bufferSize) const { | ||
| BabylonAssert(outputBuffer != nullptr); | ||
| BabylonAssert(bufferSize > 0); | ||
| size_t s = bufferSize < m_size ? bufferSize : m_size; |
Contributor
There was a problem hiding this comment.
Highlighting for tomorrow
PolygonalSun
reviewed
Jun 8, 2020
| DIRECTIONAL, | ||
| POINT, | ||
| SPOT, | ||
| UNKOWN |
PolygonalSun
reviewed
Jun 8, 2020
| }; | ||
| }; | ||
|
|
||
|
|
PolygonalSun
reviewed
Jun 8, 2020
| return Read(outputBuffer, s); | ||
| } | ||
|
|
||
|
|
PolygonalSun
reviewed
Jun 9, 2020
| return *this; | ||
| } | ||
| }; | ||
|
|
PolygonalSun
reviewed
Jun 9, 2020
| ISceneNodeUtils::DFS(&m_asset3d, [&](const SceneNode* sceneNode, const SceneNode* parentNode) | ||
| { | ||
| /* if (parentNode) { | ||
| auto& v = nodes[parentNode->GetIdString()].children; |
Contributor
There was a problem hiding this comment.
Remove commented code
PolygonalSun
reviewed
Jun 9, 2020
|
|
||
|
|
||
|
|
||
| //COLLADAFW::ColorOrTexture transparent = effectCommon->getTransparent(); |
Contributor
There was a problem hiding this comment.
If this isn't being used, remove
Contributor
|
I'd recommend using Format Document on the source code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limitations are: