Fix BRN build sourcetree#1532
Merged
CedricGuillemet merged 14 commits intoBabylonJS:masterfrom Jul 17, 2025
Merged
Conversation
CedricGuillemet
requested review from
SergioRZMasson,
bghgary,
docEdub and
ryantrem
docEdub
reviewed
Jul 9, 2025
docEdub
reviewed
Jul 9, 2025
docEdub
reviewed
Jul 9, 2025
Co-authored-by: Drew Fillebrown <andy@docEdub.com>
Member
|
Don't we have to run cmake once per platform anyway? Why not just let the dependencies be fetched when building for the specific platform? |
Contributor
Author
some users build and test the package in controled environments with mirrored registry and no direct way to download or fetch content. |
ryantrem
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to BabylonJS/BabylonReactNative#665
Some dependencies are fetched only for the platform being built.
BABYLON_NATIVE_BUILD_SOURCETREEvariable has been added to allow fetching independently of active platform.