Async shader compilation + shutdown crash repro#1393
Closed
CedricGuillemet wants to merge 5 commits intoBabylonJS:masterfrom
Closed
Async shader compilation + shutdown crash repro#1393CedricGuillemet wants to merge 5 commits intoBabylonJS:masterfrom
CedricGuillemet wants to merge 5 commits intoBabylonJS:masterfrom
Conversation
CedricGuillemet
changed the title
ryantrem
approved these changes
Jun 14, 2024
| loader.LoadScript("app:///Scripts/babylon.max.js"); | ||
| loader.LoadScript("app:///Scripts/babylonjs.materials.js"); | ||
| loader.Eval(R"( | ||
| function CreateBoxAsync(scene) { |
Member
There was a problem hiding this comment.
Maybe add a comment explaining why this needs to be an async function rather than just synchronous setup code? Not clear to me.
Contributor
Author
|
Closing in favor of #1397 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shutdown with async shader compilation crash repro.
Left as commented code: I was unable to expect a crash with GoogleTest and adding a
sleepcall to get sufficient time for shaders to be compiled was unreliable.