Skip to content

Conversation

@claude-marie
Copy link

From the pynb:
Removed the old dependancy of B.1 WorldPop Extract pipeline for population adjustment (it was 2020 data so too old)
Now we just only use the TOTAL_POPULATION_REF of the config file to adjust if we check the option to adjust

From the pipeline:
Just an enhanced information about what the option adjust_population do

see ticket:
https://bluesquare.atlassian.net/browse/SNT25-279

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the DHIS2 population transformation pipeline to simplify population adjustment by removing the dependency on the B.1 WorldPop Extract pipeline. The adjustment now relies solely on the TOTAL_POPULATION_REF value from the configuration file when the adjustment option is enabled.

Changes:

  • Removed dependency on B.1 WorldPop Extract pipeline for population adjustment
  • Simplified the adjustment logic to use only TOTAL_POPULATION_REF from config file
  • Updated documentation and help text to clarify the new adjustment behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
snt_dhis2_population_transformation/pipeline.py Enhanced help text for the adjust_population parameter to clarify it uses UN totals from config file
pipelines/snt_dhis2_population_transformation/code/snt_dhis2_population_transformation.ipynb Removed WorldPop data loading logic, simplified adjustment to use config-based TOTAL_POPULATION_REF, updated documentation, and added VS Code R language metadata
Comments suppressed due to low confidence (1)

pipelines/snt_dhis2_population_transformation/code/snt_dhis2_population_transformation.ipynb:1

  • The word 'Adjustmen' is missing the final 't'. It should be 'Adjustment'.
{

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"adjust_population",
name="Adjust using UN totals",
help="Use UN totals to scale the DHIS2 population.",
help="Adjust the DHIS2 population using the UN total (TOTAL_POPULATION_REF) specified in the config file",
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'Adjust' should be in lowercase to match sentence case conventions for help text descriptions.

Suggested change
help="Adjust the DHIS2 population using the UN total (TOTAL_POPULATION_REF) specified in the config file",
help="adjust the DHIS2 population using the UN total (TOTAL_POPULATION_REF) specified in the config file",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants