-
Notifications
You must be signed in to change notification settings - Fork 19
Toevoegen kolom 'adres_totaal' in bag views, en toevoegen van ondersteuning voor comma seperated values in mb_kvk_pand #2601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Toevoeging van kolom adres_totaal in de views eindigende op _adres
Toevoeging van kolom adres_totaal in de views eindigende op _adres
mb_kvk_pand joint op v_pand_actueel, wiens kolom 'maaktdeeluitvan' een comma seperated array is. Ondersteuning ingebouwd om ook met comma seperated values om te gaan
mb_kvk_pand joint op v_pand_actueel, wiens kolom 'maaktdeeluitvan' een comma seperated array is. Ondersteuning ingebouwd om ook met comma seperated values om te gaan
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2601 +/- ##
========================================
- Coverage 37% 37% -0%
Complexity 74 74
========================================
Files 199 199
Lines 13551 13551
Branches 1431 1431
========================================
- Hits 4903 4902 -1
Misses 8240 8240
- Partials 408 409 +1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates database views for both PostgreSQL and Oracle to support the latest iteration. The changes add a new adres_totaal (complete address) field to BAG2 address views and modify join logic in NHR views to handle comma-separated building identifiers.
- Added
adres_totaalcomputed field concatenating address components across multiple views - Updated join conditions in NHR views to support comma-separated
maaktdeeluitvanvalues - Applied consistent changes across both PostgreSQL and Oracle database platforms
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| datamodel/extra_scripts/postgresql/208_bag2_views.sql | Adds adres_totaal concatenated address field to ligplaats, standplaats, and verblijfsobject views |
| datamodel/extra_scripts/postgresql/211_nhr_views.sql | Updates join condition to handle comma-separated building IDs using array functions; adds trailing newline |
| datamodel/extra_scripts/oracle/208_bag2_views.sql | Adds adres_totaal concatenated address field to views using Oracle-specific TO_CHAR function |
| datamodel/extra_scripts/oracle/211_nhr_views.sql | Updates join condition to handle comma-separated building IDs using INSTR function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mprins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Update views to latest iteration" is ook wat er in de release notes zou komen... dus graag een beschrijvende titel van de PR, bv iets over toevoegen van een "adres totaal" kolom uit de bag oid... zodat je over 2 jaar ook nog weet wat er is gedaan
add semicolon
add semicolon
add trim
add trim
bijwerken van de extra_scripts:
-Toevoegen kolom 'adres_totaal' in bag views
-toevoegen van ondersteuning voor comma seperated values in mb_kvk_pand