Skip to content

Conversation

@de-jacco
Copy link

@de-jacco de-jacco commented Dec 9, 2025

bijwerken van de extra_scripts:
-Toevoegen kolom 'adres_totaal' in bag views
-toevoegen van ondersteuning voor comma seperated values in mb_kvk_pand

Toevoeging van kolom adres_totaal in de views eindigende op _adres
Toevoeging van kolom adres_totaal in de views eindigende op _adres
mb_kvk_pand joint op v_pand_actueel, wiens kolom 'maaktdeeluitvan' een comma seperated array is.

Ondersteuning ingebouwd om ook met comma seperated values om te gaan
mb_kvk_pand joint op v_pand_actueel, wiens kolom 'maaktdeeluitvan' een comma seperated array is.

Ondersteuning ingebouwd om ook met comma seperated values om te gaan
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37%. Comparing base (de20c62) to head (791b922).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2601   +/-   ##
========================================
- Coverage        37%     37%   -0%     
  Complexity       74      74           
========================================
  Files           199     199           
  Lines         13551   13551           
  Branches       1431    1431           
========================================
- Hits           4903    4902    -1     
  Misses         8240    8240           
- Partials        408     409    +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates database views for both PostgreSQL and Oracle to support the latest iteration. The changes add a new adres_totaal (complete address) field to BAG2 address views and modify join logic in NHR views to handle comma-separated building identifiers.

  • Added adres_totaal computed field concatenating address components across multiple views
  • Updated join conditions in NHR views to support comma-separated maaktdeeluitvan values
  • Applied consistent changes across both PostgreSQL and Oracle database platforms

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
datamodel/extra_scripts/postgresql/208_bag2_views.sql Adds adres_totaal concatenated address field to ligplaats, standplaats, and verblijfsobject views
datamodel/extra_scripts/postgresql/211_nhr_views.sql Updates join condition to handle comma-separated building IDs using array functions; adds trailing newline
datamodel/extra_scripts/oracle/208_bag2_views.sql Adds adres_totaal concatenated address field to views using Oracle-specific TO_CHAR function
datamodel/extra_scripts/oracle/211_nhr_views.sql Updates join condition to handle comma-separated building IDs using INSTR function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Update views to latest iteration" is ook wat er in de release notes zou komen... dus graag een beschrijvende titel van de PR, bv iets over toevoegen van een "adres totaal" kolom uit de bag oid... zodat je over 2 jaar ook nog weet wat er is gedaan

@de-jacco de-jacco changed the title Update views to latest iteration Toevoegen kolom 'adres_totaal' in bag views, en toevoegen van ondersteuning voor comma seperated values in mb_kvk_pand Dec 9, 2025
@mprins mprins removed the request for review from matthijsln December 22, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants