Skip to content

Conversation

@adryanalencar
Copy link

📌 Description

Please include a summary of the change and which issue is fixed.
Also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)


🧪 Type of Change

Please check the types of changes your PR introduces:

  • Bug fix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Tests added / updated

👩‍💻 Implementation Details

Provide any details on how your changes work.
If relevant, include screenshots or code snippets demonstrating behavior before/after.

🛠 Changes

  • What was added
  • What was removed
  • What was modified

✅ Checklist

Go over all the following items and check them before submitting your PR:

  • [ x ] My code follows the project’s code style (simply run spotlessApply to apply formatting)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code where necessary
  • [ x ] My changes generate no new warnings

⛓ Related Issues

Link any related issues or PRs here:


❓ Additional Notes

Add any extra information here, such as:

  • Known limitations
  • Future improvement ideas
  • Required follow-up tasks

@AzureDoom AzureDoom self-assigned this Jan 15, 2026
@AzureDoom AzureDoom added the enhancement New feature or request label Jan 15, 2026
@AzureDoom
Copy link
Owner

Hi!

Can you give a brief overview of what this is adding exactly?

@AzureDoom
Copy link
Owner

After looking at this a bit more a few things:

  • Ranks should only be enabled with boolean config option here, in which it should be default to false: https://github.com/AzureDoom/LevelingCore/blob/main/src/main/java/com/azuredoom/levelingcore/config/GUIConfig.java
  • The msg lang you added will be broken by my next update as I moved those to be lang driven and will need updated for sure. You should add a new lang option with the {rank} parm for it if you want it the chat.
  • No default ranks.yml is provided or generated for the user, which only generate when the above config option is enabled, see default.yml for how it should do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants