Adds default 30 second timeout to all prompts #6626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
requested review from
hemarina,
vhvb1989 and
weikanglim
as code owners
wbreza
requested review from
JeffreyCA,
rajeshkamal5050 and
tg-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a global, configurable timeout for interactive prompts in azd to prevent indefinite hangs in non-interactive environments (e.g., CI/CD), and improves error/suggestion messaging around prompt failures.
Changes:
- Introduces a global UX prompt timeout configuration and
ErrPromptTimeouterror type. - Applies the timeout across UX prompt components and input console interactions, with
AZD_PROMPT_TIMEOUTenv-var control. - Improves propagation/display of prompt-timeout errors (including for extensions) and captures interactive stderr for better extension error reporting.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| cli/azd/pkg/ux/select.go | Applies global prompt timeout to UX Select prompts and converts deadline errors to ErrPromptTimeout. |
| cli/azd/pkg/ux/prompt.go | Applies global prompt timeout to UX Prompt prompts and converts deadline errors to ErrPromptTimeout. |
| cli/azd/pkg/ux/multi_select.go | Applies global prompt timeout to UX MultiSelect prompts and converts deadline errors to ErrPromptTimeout. |
| cli/azd/pkg/ux/confirm.go | Applies global prompt timeout to UX Confirm prompts and converts deadline errors to ErrPromptTimeout. |
| cli/azd/pkg/ux/config.go | Adds global UX config for prompt timeout and defines ErrPromptTimeout. |
| cli/azd/pkg/ux/config_test.go | Adds unit tests for UX timeout config and ErrPromptTimeout.Error(). |
| cli/azd/pkg/input/prompt_timeout.go | Adds env-var parsing/utilities for prompt timeout in input layer. |
| cli/azd/pkg/input/prompt_timeout_test.go | Adds unit tests for env-var parsing and helper behaviors. |
| cli/azd/pkg/input/console.go | Adds timeout behavior to console interactions and default-value fallback handling. |
| cli/azd/cmd/container.go | Initializes global UX timeout from AZD_PROMPT_TIMEOUT. |
| cli/azd/cmd/middleware/ux.go | Adds prompt-timeout suggestion handling in error output. |
| cli/azd/cmd/middleware/ux_test.go | Adds tests asserting --no-prompt suggestion on ErrPromptTimeout. |
| cli/azd/cmd/extensions.go | Attempts to translate extension prompt-timeout failures into ErrPromptTimeout. |
| cli/azd/pkg/extensions/runner.go | Includes captured stderr in ExtensionRunError for more informative failures. |
| cli/azd/pkg/exec/command_runner.go | Captures stdout/stderr even for interactive commands and marks output available for errors. |
| cli/azd/internal/errors_test.go | Adds tests for ErrorWithSuggestion behavior. |
| cli/azd/extensions/microsoft.azd.demo/internal/cmd/prompt.go | Fixes demo extension prompt command to return errors instead of swallowing them. |
| cli/azd/docs/environment-variables.md | Documents the new AZD_PROMPT_TIMEOUT environment variable. |
Comments suppressed due to low confidence (3)
cli/azd/pkg/exec/command_runner.go:182
- By forcing outputAvailable=true for ExitError (including interactive runs), stdout/stderr will now be embedded into error strings. This can unintentionally leak secrets or large amounts of output into user-facing errors/logs (interactive commands often print tokens, env dumps, etc.). Consider keeping outputAvailable=false for interactive runs (as before) or sanitizing/truncating output before attaching it to ExitError.
// Output is now always available since we capture even for interactive commands
err = NewExitError(
*exitErr,
args.Cmd,
result.Stdout,
result.Stderr,
true)
cli/azd/pkg/exec/command_runner.go:123
- Capturing stdout/stderr into unbounded bytes.Buffers for interactive commands can lead to high memory usage if an interactive process is noisy/long-running. If the goal is mainly to surface extension errors, consider capturing only stderr, or capping captured output to the last N bytes.
cmd.Stdin = r.stdin
// Use MultiWriter to both display to terminal AND capture output
cmd.Stdout = io.MultiWriter(r.stdout, &stdout)
cmd.Stderr = io.MultiWriter(r.stderr, &stderr)
} else {
cli/azd/pkg/input/console.go:622
- Timeout fallback for Prompt only applies when the default string is non-empty. However, promptFromOptions will pass through an explicitly configured empty-string DefaultValue (which survey treats the same as “no default”). This creates inconsistent semantics: callers that set DefaultValue: "" will not get fallback behavior on timeout. Consider standardizing by either treating empty string as “no default” everywhere (don’t set it on the survey prompt), or treating any explicitly provided string (including empty) as an available default for timeout fallback.
// Handle prompt timeout - return default value if available
var timeoutErr *uxlib.ErrPromptTimeout
if errors.As(err, &timeoutErr) {
if defaultValue, ok := options.DefaultValue.(string); ok && defaultValue != "" {
return defaultValue, nil
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vhvb1989
reviewed
Jan 28, 2026
JeffreyCA
reviewed
Jan 28, 2026
JeffreyCA
reviewed
Jan 28, 2026
vhvb1989
approved these changes
Jan 28, 2026
tg-msft
approved these changes
Jan 28, 2026
JeffreyCA
approved these changes
Jan 28, 2026
vhvb1989
approved these changes
Jan 28, 2026
Member
vhvb1989
left a comment
vhvb1989
left a comment
There was a problem hiding this comment.
Consider creating an issue to link this and make it part of the sprint
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic Prompt Timeout Feature
What Changed
Added automatic 30-second timeout for all interactive prompts in
azd, configurable viaAZD_PROMPT_TIMEOUTenvironment variable.Business Justification
Problem: In CI/CD pipelines, automated scripts, and coding agent scenarios,
azdcommands can hang indefinitely waiting for user input that will never come - blocking pipelines, wasting compute resources, and causing deployment failures.Solution: Prompts now automatically timeout after 30 seconds (configurable), failing fast with a clear error message and actionable suggestion to set
--no-promptor provide required inputs.Behavior
AZD_PROMPT_TIMEOUTValue0or negativeUser Experience
When a prompt times out, users see:
Impact
AZD_PROMPT_TIMEOUT=0to restore old behavior