feat: enable configuration of repository visibility

[kimfy]

Overview/Summary

This pull request enables the configuration of GitHub repository visibility via a new configuration parameter repository_visibility. This allows users to set the visibility to either private, public or internal explicitly.

The current implementation defaults to public visibility if the organization has the free plan. Which you may not want out of the box.

For reference, GitHub supports private repositories for any plan.

This PR fixes/adds/changes/removes

1. Adds a new configuration parameter repository_visibility
2. Defaults repository_visibility to private

Breaking Changes

1. Default value for repository_visibility is set to private for any plan. So GitHub Users/Organizations with the free plan changes from public to private.

Testing Evidence

When testing, I ran the bootstrap procedure 4 times (using ALZ-PowerShell-Module). On each run I set repository_visibility to: private|public|internal and lastly commented it completely out (from input-github.yaml). Once the first terraform plan was finished I confirmed with the plan output (tfplan) and terraform.tfvars.json that it would create the GitHub repositories with repository_visibility set to the configured value.

As part of this Pull Request I have

• Checked for duplicate Pull Requests
• Associated it with relevant issues, for tracking and closure.
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated relevant and associated documentation.

[kimfy]

I have an additional question regarding documentation changes. Am I expected to create a pull request in the below repository?

https://github.com/Azure/alz-terraform-accelerator

[kimfy]

@microsoft-github-policy-service agree [company="{blinQ}"]

[kimfy]

@microsoft-github-policy-service agree company="blinQ"

[jaredfholgate]

@kimfy There are many features that don't work with private repositories in a Free plan, hence why we set them to public. If we implement this setting we would need to also add logic to all those features and turn them off.

You can see all the features that are only available for public repos here: https://github.com/pricing#compare-features

[jaredfholgate]

I have an additional question regarding documentation changes. Am I expected to create a pull request in the below repository?

https://github.com/Azure/alz-terraform-accelerator

• Documentation is here: https://github.com/Azure/Azure-Landing-Zones/tree/main/docs/content/accelerator/userguide/2_start
• Example configuration files are here:
  • https://github.com/Azure/alz-terraform-accelerator/tree/main/templates/platform_landing_zone/examples/bootstrap
  • https://github.com/Azure/alz-terraform-accelerator/tree/main/templates/microsoft_cloud_for_industry/financial_services_landing_zone/examples/bootstrap
  • https://github.com/Azure/alz-terraform-accelerator/tree/main/templates/microsoft_cloud_for_industry/sovereign_landing_zone/examples/bootstrap
  • https://github.com/Azure/ALZ-Bicep/tree/main/accelerator/examples/bootstrap

[kimfy]

@jaredfholgate I understand. I'll have a look at the work that needs to be done to support this then. Thanks.

By the way, it is currently not possible to create new issues in this repository.

Edit: it's probably a preview-bug. If I go directly to https://github.com/Azure/accelerator-bootstrap-modules/issues/new/ it works.

[jaredfholgate]

@jaredfholgate I understand. I'll have a look at the work that needs to be done to support this then. Thanks.

By the way, it is currently not possible to create new issues in this repository.

Edit: it's probably a preview-bug. If I go directly to https://github.com/Azure/accelerator-bootstrap-modules/issues/new/ it works.

Yes, we are aware of this problem with the preview. It should be redirecting you here to raise all issues, but is currently broken in the preview: https://github.com/Azure/ALZ-PowerShell-Module/issues